SFTP reads are supposed to be binary, so don't wrap with str() #15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 similar comment
Open
|
@ulope @WeatherGod can we merge this fix and re-publish the package? I ran into this issue as well. Looks like others have as well (e.g. januarytech@3635846). |
Owner
|
Sorry for being so slow reacting to PRs here. I'll look into this on the weekend and release a new version then. |
ulope
force-pushed
the
master
branch
13 times, most recently
from
bfaaa6d to
95a3bc8
Compare
(cherry picked from commit 8d7a323)
|
Code Climate has analyzed commit ef0817e and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (80% is the threshold). This pull request will bring the total coverage in the repository to 98.4% (0.1% change). View more on Code Climate. |
Owner
|
Merged. Thanks for the fix, and again apologies for it having taken so long. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Discovered this as I was porting a project over to py3k. My tests had some round-trippers that were ending up as
b"b'foobar'", which would fail my unit test. This happens in py3k when casting a bytes object into a string. Since paramiko does everything as bytes in py3k (as per the SFTP specs), this would result in bad results being read back in a round-trip scenario.The existing tests didn't notice this because any tests that wrote to the content provider never read it back, and any tests that read stuff back only read back entries in the existing content provider fixture. which were are already string objects. I added a round-trip test that fails without this change and passes with it.