-
Notifications
You must be signed in to change notification settings - Fork 295
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
codec: streamline library: refactor sendContainerState and clean up h…
…andle-specific test flags refactor sendContainerState to be methods on (en|de)cDriver Basically, move from sendContainerState to roughly (Read|Write)(Array|Map)(Elem)(Key|Value)(Start|End) Support IndefiniteLength in cbor during encoding test: make testUseIoEncDec an int flag, which specifies buffer size It defaults to -1, which means do not use io. if >= 0, then we use io.Reader/io.Writer with a buffer in front. test: do not use flags for handle-specific configuration Instead, create suite groups for each handle, and modify the configuration for the test group, and execute the handle-specific tests.
- Loading branch information
Showing
20 changed files
with
5,459 additions
and
6,823 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
c3953de
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This broke etcd client :(
c3953de
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
https://github.com/coreos/etcd/blob/master/client/keys.generated.go#L55
c3953de
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@georgekarrv Did you recreate codecgen and then re-generate the files?
c3953de
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
etcd-io/etcd#8715