`go get github.com/cores/etcd/client` fails on generated code

[kemitche]

As of the current commit (a8f9de2), I'm unable to cleanly go get github.com/coreos/etcd/client for use as a library. The build fails when looking at keys.generated.go.

Running go generate resolves compilation, though go test github.com/coreos/etcd/client still fails.

kmitchell @ kmitchell-laptop ~
└─ 0 $ ▶ go get github.com/coreos/etcd/client
# github.com/coreos/etcd/client
go3/src/github.com/coreos/etcd/client/keys.generated.go:72:6: r.EncodeArrayStart undefined (type codec.encDriver has no field or method EncodeArrayStart)
go3/src/github.com/coreos/etcd/client/keys.generated.go:80:6: r.EncodeMapStart undefined (type codec.encDriver has no field or method EncodeMapStart)
go3/src/github.com/coreos/etcd/client/keys.generated.go:83:6: z.EncSendContainerState undefined (type codec.genHelperEncoder has no field or method EncSendContainerState)
go3/src/github.com/coreos/etcd/client/keys.generated.go:91:6: z.EncSendContainerState undefined (type codec.genHelperEncoder has no field or method EncSendContainerState)
go3/src/github.com/coreos/etcd/client/keys.generated.go:93:6: z.EncSendContainerState undefined (type codec.genHelperEncoder has no field or method EncSendContainerState)
go3/src/github.com/coreos/etcd/client/keys.generated.go:102:6: z.EncSendContainerState undefined (type codec.genHelperEncoder has no field or method EncSendContainerState)
go3/src/github.com/coreos/etcd/client/keys.generated.go:109:6: z.EncSendContainerState undefined (type codec.genHelperEncoder has no field or method EncSendContainerState)
go3/src/github.com/coreos/etcd/client/keys.generated.go:111:6: z.EncSendContainerState undefined (type codec.genHelperEncoder has no field or method EncSendContainerState)
go3/src/github.com/coreos/etcd/client/keys.generated.go:119:6: z.EncSendContainerState undefined (type codec.genHelperEncoder has no field or method EncSendContainerState)
go3/src/github.com/coreos/etcd/client/keys.generated.go:126:6: z.EncSendContainerState undefined (type codec.genHelperEncoder has no field or method EncSendContainerState)
go3/src/github.com/coreos/etcd/client/keys.generated.go:126:6: too many errors

Workarounds I've used:

• Vendoring an older version of etcd/client and codecgen packages works around the issue.
• clientv3 builds and passes tests.
• Cloning the etcd repo separately, then using glide to pull in the repo's dependencies, results in a successful build & test of github.com/coreos/etcd/client. This isn't viable on its own for use as a library in other projects, but merging the etcd glide files with the project's glide file could work to get a functional build.

[georgekarrv]

ugorji/go@c3953de

is what broke this.

[andrewmeissner]

I have failing application builds due to this. :( I've been able to revert back to older containers for the time being. How soon can my team expect a fix/rollback? Thanks!

[ugorji]

^^ @georgekarrv @andrewmeissner

codecgen tool goes with the codecgen version.

My sense is that folks updated the codec library, but didn't rebuild the codecgen tool before re-generating the files.

The sequence should be something similar to:

go get -u github.com/ugorji/go/codec (this should download the codec library)
go get -u github.com/ugorji/go/codec/codecgen (this will rebuild the codecgen executable)
codecgen ..... (now run the codecgen executable)

I think it may be sufficient to re-build the codecgen executable, so it matches the codec library.

[andrewmeissner]

@ugorji I've never had to use the codecgen executable before. How/Where should I run that?

[ugorji]

Someone from the coreos team runs it. At a certain point, they will update their vendored copy of github.com/ugorji/go/codec/..., rebuild the codecgen executable, regenerate files like keys.generated.go .

[gyuho]

We've regenerated here #8574.

[andrewmeissner]

@gyuho I've deleted etcd from my gopath, and am still getting the same errors on go get. Am I still missing something?

[gyuho]

Did you try go get -v -u github.com/ugorji/go/codec/... as @ugorji suggested?

[andrewmeissner]

@gyuho yes :( I also tried completely removing them + etcd again from my gopath and still get the same errors.

[ugorji]

@gyuho I think you need to re-generate the files again and check into source control. They were last generated on sept 19 or so. I updated the codecgen version to 8.

I also think you should consider vendoring codec in etcd client, since you use generated files in there.

[gyuho]

@ugorji Ok thanks! Will try that.

[andrewmeissner]

Any ETA on this? I can't resume active development until this is fixed... :(

[gyuho]

@andrewmeissner Help is always welcome! Currently we are busy with clientv3 fixes. Sorry!