LIE/HM part 2: Data structure #1538
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
endJunction
approved these changes
Nov 15, 2016
|
@wenqing can you please review this? |
chleh
approved these changes
Nov 17, 2016
| { | ||
| } | ||
|
|
||
| typename HMatricesType::HMatrixType H_u; |
There was a problem hiding this comment.
Note: Default-constructing these matrices might fail miserably if they are of dynamic size. Currently that probably doesn't matter, because displacement-related stuff is always fixed size.
There was a problem hiding this comment.
yes, it's fixed size matrix. but isn't Jenkins testing both Eigen dynamic size matrix and fixed size matrix cases?
There was a problem hiding this comment.
I see, I was confused.
If you resize the matrices in your assembler, or assign to them as a whole, not component-wise, s.t. they have a proper size in the end, there will be no problem.
|
OpenGeoSys development has been moved to GitLab. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
a part of #1535, depends on #1537
This PR focuses on data structures used in LIE/HM, i.e. process data and integration point data