LIE/HM part 1: prerequisite #1537
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chleh
reviewed
Nov 11, 2016
| { | ||
|
|
||
| template <int DisplacementDim> | ||
| struct FractureIdentity2 |
There was a problem hiding this comment.
Could you please add some documentation? And why is there a two at the end of the class name? At least I cannot see an already existing file FractureIdentity.h?
There was a problem hiding this comment.
this corresponds to Invariants::identity2 in KelvinVector.h for usual solids. I will add some comment there
|
👍 |
|
Something is going wrong with conan and that's why Travis is failing. this is nothing to do with this PR. |
|
@wenqing or @endJunction can you please review this? |
endJunction
approved these changes
Nov 15, 2016
|
OpenGeoSys development has been moved to GitLab. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
a part of #1535
This PR includes changes required for implementing HM process with the LIE approach. Please check each commit