refactor: Simplify/cleanup officer data approach

[WillBAnders]

PR split from #35 for review. This has a few changes; may be worth looking at specific commits.

• OfficerData has been cleaned up and duplicate entries removed (there was both officerData and the older officerCardData). In general, the approach here is that officerData contains personal information about an officer. Information about positions is only present as part of positionData later on, which references the corresponding officer in officerData. This is the primary improvement in this PR.
  • This was the original intent with having both a separation of concerns - effectively, abstracting the shared (officer) information about positions into it's own constant that can be reused.
  • Note that there is a now a new OfficerData type which is used by OfficerCardProps rather than using OfficerCardProps directly - in general, types for data should be kept separate from any component prop types. This also helps avoids circular dependencies.
• The socialLinksData field has been replaced by socials (just a slightly nicer name) that is map of site to url. This greatly simplifies the amount of data that needs to be stored for each officer, as the icon image path can be looked up separately.
• Minor key attribute improvements while here.

[WillBAnders]

[Comment]: This is actually an interesting case - above I changed socials to be an map instead of an array, here I probably would have gone in the other direction. Having positions be a map feels a little weirder to me; in part because there's not really any mapping to look up values here - rather it fully relies on iteration order. I think the fact that the keys have spaces too certainly doesn't help this.

Either way; let's leave this as is - any change is a style preference and doesn't have any additional benefit/savings right now.

[Phantom0110]

Wow, that looks a lot cleaner. Really helped remove a lot of unnecessary long repeats of code. I was confused about the difference between officerCardData and officerData so that helps clear things up. Awesome work!