Improve key attributes for array components

ufssd · Dec 13, 2023 · 3e46aee · 3e46aee
1 parent 53b5a31
commit 3e46aee
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 6 deletions.
diff --git a/src/app/about/officer-card.tsx b/src/app/about/officer-card.tsx
@@ -15,7 +15,7 @@ export type OfficerCardProps = {
 
 export default function OfficerCard({ position, officer }: OfficerCardProps) {
   const socialLinks = Object.entries(officer.socials).map(([site, url]) => (
-    <a href={url} key={site} target="_blank" rel="noopener noreferrer">
+    <a key={site} href={url} target="_blank" rel="noopener noreferrer">
       <Image
         src={socialIcons[site as SocialSite]} // cast key from Object.entries
         alt={site}

diff --git a/src/app/about/page.tsx b/src/app/about/page.tsx
@@ -11,11 +11,7 @@ export default function About() {
       const officerCards = Object.entries(officers).map(
         ([position, officer]) => {
           return (
-            <OfficerCard
-              key={`${semester} ${position}`}
-              position={position}
-              officer={officer}
-            />
+            <OfficerCard key={position} position={position} officer={officer} />
           );
         },
       );