chore: Remove .idea files #27
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Brian-Magnuson
approved these changes
Nov 5, 2023
There was a problem hiding this comment.
I personally prefer adding to the .gitignore and I think it would be good for this project. Only thing is that I don't have nearly as much experience with Git as you, @WillBAnders, so maybe you know best. I'll approve these changes, so you can merge if you want to.
|
@Brian-Magnuson Mentioned on Discord; I'm not a fan personally but if y'all want to set one up feel free. Either way, these files need to be removed from the project so this has to be merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These files were added in #11 and should not have been committed. Using a
.gitignorecan help with this, though my personal "hot take" is that.gitignorecan be a crutch and it's better to pay close attention to what files are being committed and never rely ongit add .(especially when working across repositories, as the.gitignoreconfiguration may vary). YMMV.