Feature: Configure initial landing page (styling and background image) #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WillBAnders
requested changes
Oct 17, 2023
…4 and also 6 and adjusted margins.
Put background position to be center and the background size to cover
Fixed EOF newline, Added color to text TEMPORARY Co-Authored-By: Nqnt41 <93019930+Nqnt41@users.noreply.github.com>
JavierM333
approved these changes
Oct 19, 2023
WillBAnders
requested changes
Oct 20, 2023
| @@ -0,0 +1,5 @@ | |||
| # Default ignored files | |||
There was a problem hiding this comment.
[Please Change]: These .idea files should not be committed. Be careful using git add . (or other add-all commands); I tend to add files/directories specifically.
src/app/globals.css
Outdated
| margin-right: 1em; | ||
| } | ||
|
|
||
| .p-landing-text { |
There was a problem hiding this comment.
[Comment]: This conflates two ideas, the HTML tag (p) and semantic meaning (landing-text) using a CSS class - you would generally either do one or the other. I would lean towards styling by tag (e.g. p) and only use a class for exceptions to default rules.
No need to change anything here; I'll handle this as part of global styling.
WillBAnders
approved these changes
Oct 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #3. Added basic landing page with desired headings, text, simple styling, and background image that covers whole screen. Starting point upon which to further develop page. Background image found in public folder of repo.