-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: Configure initial landing page (styling and background image) #11
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Requesting changes for some style cleanup/improvements and splitting that into a CSS module now that we know how it's done. We can sync tomorrow on that and go through it together if you'd like.
…4 and also 6 and adjusted margins.
Put background position to be center and the background size to cover
Fixed EOF newline, Added color to text TEMPORARY Co-Authored-By: Nqnt41 <93019930+Nqnt41@users.noreply.github.com>
@@ -0,0 +1,5 @@ | |||
# Default ignored files |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[Please Change]: These .idea
files should not be committed. Be careful using git add .
(or other add-all commands); I tend to add files/directories specifically.
src/app/globals.css
Outdated
margin-right: 1em; | ||
} | ||
|
||
.p-landing-text { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[Comment]: This conflates two ideas, the HTML tag (p
) and semantic meaning (landing-text
) using a CSS class - you would generally either do one or the other. I would lean towards styling by tag (e.g. p
) and only use a class for exceptions to default rules.
No need to change anything here; I'll handle this as part of global styling.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Phantom0110 Thanks for jumping in on this!
Resolves #3. Added basic landing page with desired headings, text, simple styling, and background image that covers whole screen. Starting point upon which to further develop page. Background image found in public folder of repo.