Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix eslint-config-next version in package.json #25

Merged
merged 1 commit into from
Oct 31, 2023
Merged

Fix eslint-config-next version in package.json #25

merged 1 commit into from
Oct 31, 2023

Conversation

WillBAnders
Copy link
Member

This version was missed in #24. The version pinned in package-lock.json is correct (^13.5.6), so this discrepancy causes writes to package-lock.json when running npm install.

angel1254mc
angel1254mc approved these changes Oct 31, 2023
View reviewed changes
Copy link
Contributor

@angel1254mc angel1254mc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch, LGTM 🥳

@WillBAnders WillBAnders merged commit d09b1e5 into master Oct 31, 2023
1 check passed
@WillBAnders WillBAnders deleted the fix/eslint-config-next-package-version branch October 31, 2023 22:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@angel1254mc angel1254mc angel1254mc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@WillBAnders @angel1254mc