Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: Update Dependencies #24

Merged
merged 3 commits into from
Oct 28, 2023
Merged

Chore: Update Dependencies #24

merged 3 commits into from
Oct 28, 2023

Conversation

angel1254mc
Copy link
Contributor

This PR updates most dependencies to their latest versions. Outdated dependencies were found using npm outdated and they were updated with npm update wooo 🥳🥳.

Resolves #20. A couple of dependencies w/ possible breaking changes like next and eslint-config-next will be updated in a separate PR :)

Copy link
Member

@WillBAnders WillBAnders left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a few comments on quirks from manual updates. There's a tool called npm-check-updates which is much better at these types of things than NPM itself; I forgot to include in the issue but that's what I would recommend and it handles this well.

npx npm-check-updates --format group
npx npm-check-updates --upgrade --target minor --format group

"@types/node": "^20.8.3",
"@types/react": "^18.2.25",
"@types/react-dom": "^18.2.11",
"@types/node": "^20.8.9",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[Please Change]: Dependency versions in package.json are also included in package-lock.json - you need to run npm install after updating the versions here.

"autoprefixer": "^10.4.16",
"eslint": "^8.51.0",
"eslint": "^8.52.0",
"eslint-config-airbnb": "^19.0.4",
"eslint-config-airbnb-typescript": "^17.1.0",
"eslint-config-next": "^13.5.4",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[Please Consider]: While the latest version of eslint-config-next (and next) is v14, there is a more recent v13.5.6 release which is available as well. In general it's good to update to latest minor prior to making the major jump.

Copy link
Member

@WillBAnders WillBAnders left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Discussed changes over a call!

@angel1254mc angel1254mc merged commit 27316af into master Oct 28, 2023
1 check passed
@angel1254mc angel1254mc deleted the chore/update-dependencies branch October 28, 2023 18:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

(Sprint 2) Update dependencies
2 participants