Update UPP control files for GFS, RRFS and HAFS #646

WenMeng-NOAA · 2021-06-15T17:46:45Z

PR Checklist

Ths PR is up-to-date with the top of all sub-component repositories except for those sub-components which are the subject of this PR. Please consult the ufs-weather-model wiki if you are unsure how to do this.
This PR has been tested using a branch which is up-to-date with the top of all sub-component repositories except for those sub-components which are the subject of this PR
An Issue describing the work contained in this PR has been created either in the subcomponent(s) or in the ufs-weather-model. The Issue should be created in the repository that is most relevant to the changes in contained in the PR. The Issue and the dependent sub-component PR
are specified below.
If new or updated input data is required by this PR, it is clearly stated in the text of the PR.

Instructions: All subsequent sections of text should be filled in as appropriate.

The information provided below allows the code managers to understand the changes relevant to this PR, whether those changes are in the ufs-weather-model repository or in a subcomponent repository. Ufs-weather-model code managers will use the information provided to add any applicable labels, assign reviewers and place it in the Commit Queue. Once the PR is in the Commit Queue, it is the PR owner's responsiblity to keep the PR up-to-date with the develop branch of ufs-weather-model.

Description

Provide a detailed description of what this PR does. What bug does it fix, or what feature does it add? Is a change of answers expected from this PR? Are any library updates included in this PR (modulefiles etc.)?
This PR is for

Updating the post control files for GFS, RRFS an
Updating grib2 table params_grib2_tbl_new used in inline post
Updating upp lib to 10.0.8
Updating g2tmpl lib to 1.10.0

There will be changes of grib2 files from inline post for GFS, RRFS and HAFS.

Issue(s) addressed

Link the issues to be closed with this PR, whether in this repository, or in another repository.
(Remember, issues must always be created before starting work on a PR branch!)

fixes Update the UPP control files used by GFS, RRFS and HAFS and upp/10.0.8 #643

Testing

How were these changes tested? What compilers / HPCs was it tested with? Are the changes covered by regression tests? (If not, why? Do new tests need to be added?) Have regression tests and unit tests (utests) been run? On which platforms and with which compilers? (Note that unit tests can only be run on tier-1 platforms)

Dependencies

None

…files for GFS, RRFS HAFS and grib2 table.

modulefiles/ufs_common

Merge remote-tracking branch 'upstream/develop' into feature/upp_control_files

climbfuji

I don't know much about the postconfig files, the rest looks good to me.

BrianCurtis-NOAA · 2021-06-17T01:46:17Z

Machine: hera
Compiler: intel
Job: BL
Repo location: /scratch1/NCEPDEV/nems/emc.nemspara/autort/pr/670620714/20210617014520/ufs-weather-model
Please make changes and add the following label back:
hera-intel-BL

on-behalf-of @ufs-community

…fs-weather-model into feature/upp_control_files

on-behalf-of @ufs-community

BrianCurtis-NOAA · 2021-06-17T05:26:09Z

Machine: jet
Compiler: intel
Job: BL
Repo location: /lfs4/HFIP/h-nems/emc.nemspara/autort/pr/670620714/20210617013010/ufs-weather-model
Please manually delete: /lfs4/HFIP/h-nems/emc.nemspara/RT_RUNDIRS/emc.nemspara/FV3_RT/rt_269986
Baseline creation and move successful
Repo location: /lfs4/HFIP/h-nems/emc.nemspara/autort/pr/670620714/20210617031749/ufs-weather-model
Please manually delete: /lfs4/HFIP/h-nems/emc.nemspara/RT_RUNDIRS/emc.nemspara/FV3_RT/rt_96577
Test control_c384 021 failed failed
Test control_c384 021 failed in run_test failed
Please make changes and add the following label back:
jet-intel-BL

junwang-noaa · 2021-06-17T12:41:06Z

on jet:
[186:x159] unexpected DAPL connection event 0x4008 from 376
Fatal error in PMPI_Wait: Internal MPI error!, error stack:
PMPI_Wait(219)...........: MPI_Wait(request=0x1e365ba0, status=0x1) failed
MPIR_Wait_impl(81).......: fail failed
PMPIDI_CH3I_Progress(850): fail failed
(unknown)(): Internal MPI error!

The control_c384 test was rerun and passed.

2) Update rt.conf to turn on regional_quilt and regional_has and regional_quilt_RRTMG on wcoss_cray. 3) RT JOBS PASSED: wcoss_cray.log file uploaded.

BrianCurtis-NOAA · 2021-06-17T13:09:20Z

Machine: hera
Compiler: intel
Job: BL
Repo location: /scratch1/NCEPDEV/nems/emc.nemspara/autort/pr/670620714/20210617123010/ufs-weather-model
Please manually delete: /scratch1/NCEPDEV/stmp2/emc.nemspara/FV3_RT/rt_129165
Please make changes and add the following label back:
hera-intel-BL

junwang-noaa · 2021-06-17T13:29:10Z

Machine: hera
Compiler: intel
Job: BL
Repo location: /scratch1/NCEPDEV/nems/emc.nemspara/autort/pr/670620714/20210617123010/ufs-weather-model
Please manually delete: /scratch1/NCEPDEV/stmp2/emc.nemspara/FV3_RT/rt_129165
Please make changes and add the following label back:
hera-intel-BL

@BrianCurtis-NOAA hera-intel-BL failed again, can you check?

junwang-noaa · 2021-06-17T13:42:11Z

@MinsukJi-NOAA In this PR, the g2(3.4.2), g2tmpl (1.10.0) and upp (10.0.8) libraries are updated, do we need to update the CI test to load those new libraries?

MinsukJi-NOAA · 2021-06-17T13:56:52Z

@MinsukJi-NOAA In this PR, the g2(3.4.2), g2tmpl (1.10.0) and upp (10.0.8) libraries are updated, do we need to update the CI test to load those new libraries?

The CI tests passed, so I think it is okay for this PR. But I am going to update and test the container with those libraries for a future PR.

BrianCurtis-NOAA · 2021-06-17T18:19:15Z

[18:17:49]Brian.Curtis@hfe08:/scratch1/NCEPDEV/nems/emc.nemspara/autort/pr/670620714/20210617123010/ufs-weather-model/tests
-->tail -f RegressionTests_hera.intel.log
 Moving RESTART/sfc_data.tile6.nc .........OK

  0: The total amount of wall time                        = 332.127790

Test 080 control_atmwav PASS


REGRESSION TEST WAS SUCCESSFUL
Thu Jun 17 13:09:20 UTC 2021
Elapsed time: 00h:36m:50s. Have a nice day!

Seems like it was OK, all files were moved over to the baseline storage and it doesn't look like anything is missing. I've added the RT label, hopefully it goes quick, apologies for the delay.

junwang-noaa · 2021-06-17T19:11:10Z

@BrianCurtis-NOAA I manually submit hera intel RT, it's now done.

@WenMeng-NOAA the hera intel log file is available at:/scratch1/NCEPDEV/nems/Jun.Wang/nems/vlab/20210616/test/ufs-weather-model/tests/RegressionTests_hera.intel.log
Please commit it to your branch

BrianCurtis-NOAA · 2021-06-17T19:11:48Z

Looks like the hera.intel label is done, just waiting on the comparison and log file upload.

on-behalf-of @ufs-community

BrianCurtis-NOAA · 2021-06-17T19:17:01Z

@WenMeng-NOAA looks like the AutoRT finished and uploaded a successful log file for you. You can skip uploading it yourself.

WenMeng-NOAA · 2021-06-17T19:20:09Z

@junwang-noaa , @BrianCurtis-NOAA Thanks for running rt tests and committing the log files.

## DESCRIPTION OF CHANGES: 1. Add capability to turn on/off those workflow tasks that currently do not have this capability. These tasks are: a. Getting the external model files for creating initial conditions (`GET_EXTRN_ICS_TN`). b. Getting the external model files for creating boundary conditions (`GET_EXTRN_LBCS_TN`). c. Regridding/interpolating data from the external model IC files to obtain IC fields on the native grid (`MAKE_ICS_TN`). d. Regridding/interpolating data from the external model LBC files to obtain LBC fields on the native grid (`MAKE_LBCS_TN`). e. Running the forecast (`RUN_FCST`). Note that any remaining tasks in the workflow already have the capability to be toggled on/off. 2. Add a WE2E test (named `deactivate_tasks`) to test the ability to turn off tasks. In this test, all the tasks except `MAKE_GRID_TN`, `MAKE_OROG_TN`, and `MAKE_SFC_CLIMO_TN` are turned off (the latter 3 are not turned off because there is already a separate WE2E for turning those three off). ## TESTS CONDUCTED: Ran the new WE2E test (`deactivate_tasks`) successfully on Hera. ## DOCUMENTATION: Necessary documentation has been included in `config_defaults.sh`. Created Issue #646 to also update rst documentation.

1)Update with g2tmpl/1.10.0 and upp/10.0.8; 2)Update the UPP control …

40f2e30

…files for GFS, RRFS HAFS and grib2 table.

junwang-noaa reviewed Jun 16, 2021

View reviewed changes

modulefiles/ufs_common Outdated Show resolved Hide resolved

1)Update g2/3.4.2; 2)Change BL_DATE to 20210616 in rt.sh.

7a2ccb9

junwang-noaa requested a review from DusanJovic-NOAA June 16, 2021 20:01

Merge with upstream/develop and solve conflict in rt.sh.

700d14a

Merge remote-tracking branch 'upstream/develop' into feature/upp_control_files

junwang-noaa requested a review from climbfuji June 16, 2021 20:03

junwang-noaa added the Baseline Updates Current baselines will be updated. label Jun 16, 2021

climbfuji approved these changes Jun 16, 2021

View reviewed changes

junwang-noaa approved these changes Jun 16, 2021

View reviewed changes

DusanJovic-NOAA approved these changes Jun 16, 2021

View reviewed changes

junwang-noaa added cheyenne-gnu-BL labels Jun 17, 2021

BrianCurtis-NOAA removed cheyenne-gnu-BL labels Jun 17, 2021

BrianCurtis-NOAA and others added 6 commits June 16, 2021 20:15

RT JOBS PASSED: cheyenne.gnu. Log file uploaded.

1dcfc51

on-behalf-of @ufs-community

RT JOBS PASSED: cheyenne.intel. Log file uploaded.

fd0505a

on-behalf-of @ufs-community

RT JOBS PASSED: wcoss_dell_p3.log file uploaded.

9a9d350

Merge branch 'feature/upp_control_files' of github.com:WenMeng-NOAA/u…

45bd58c

…fs-weather-model into feature/upp_control_files

RT JOBS PASSED: gaea.intel. Log file uploaded.

12f38dd

on-behalf-of @ufs-community

RT JOBS PASSED: hera.gnu. Log file uploaded.

6322bc0

on-behalf-of @ufs-community

junwang-noaa added the run-ci label Jun 17, 2021

github-actions bot removed the run-ci label Jun 17, 2021

junwang-noaa added the hera-intel-BL label Jun 17, 2021

BrianCurtis-NOAA removed the hera-intel-BL label Jun 17, 2021

1) Update ufs module for wcoss_cray with upp/10.0.8 and g2tmp2/1.10.0.

0f7d3d0

2) Update rt.conf to turn on regional_quilt and regional_has and regional_quilt_RRTMG on wcoss_cray. 3) RT JOBS PASSED: wcoss_cray.log file uploaded.

RT JOBS PASSED: jet.intel.log uploaded.

731df0a

BrianCurtis-NOAA added hera-intel-RT and removed hera-intel-RT labels Jun 17, 2021

RT JOBS PASSED: hera.intel. Log file uploaded.

c71694f

on-behalf-of @ufs-community

junwang-noaa merged commit aa2ab44 into ufs-community:develop Jun 17, 2021

MinsukJi-NOAA mentioned this pull request Jun 21, 2021

Update FV3 (Thompson MP and RRTMGP), CMEPS, documentation and CI #619

Merged

14 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update UPP control files for GFS, RRFS and HAFS #646

Update UPP control files for GFS, RRFS and HAFS #646

WenMeng-NOAA commented Jun 15, 2021 •

edited by junwang-noaa

Loading

climbfuji left a comment

BrianCurtis-NOAA commented Jun 17, 2021

BrianCurtis-NOAA commented Jun 17, 2021

junwang-noaa commented Jun 17, 2021

BrianCurtis-NOAA commented Jun 17, 2021

junwang-noaa commented Jun 17, 2021

junwang-noaa commented Jun 17, 2021

MinsukJi-NOAA commented Jun 17, 2021

BrianCurtis-NOAA commented Jun 17, 2021

junwang-noaa commented Jun 17, 2021

BrianCurtis-NOAA commented Jun 17, 2021

BrianCurtis-NOAA commented Jun 17, 2021

WenMeng-NOAA commented Jun 17, 2021

Update UPP control files for GFS, RRFS and HAFS #646

Update UPP control files for GFS, RRFS and HAFS #646

Conversation

WenMeng-NOAA commented Jun 15, 2021 • edited by junwang-noaa Loading

PR Checklist

Instructions: All subsequent sections of text should be filled in as appropriate.

Description

Issue(s) addressed

Testing

Dependencies

climbfuji left a comment

Choose a reason for hiding this comment

BrianCurtis-NOAA commented Jun 17, 2021

BrianCurtis-NOAA commented Jun 17, 2021

junwang-noaa commented Jun 17, 2021

BrianCurtis-NOAA commented Jun 17, 2021

junwang-noaa commented Jun 17, 2021

junwang-noaa commented Jun 17, 2021

MinsukJi-NOAA commented Jun 17, 2021

BrianCurtis-NOAA commented Jun 17, 2021

junwang-noaa commented Jun 17, 2021

BrianCurtis-NOAA commented Jun 17, 2021

BrianCurtis-NOAA commented Jun 17, 2021

WenMeng-NOAA commented Jun 17, 2021

WenMeng-NOAA commented Jun 15, 2021 •

edited by junwang-noaa

Loading