Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update FV3 (Thompson MP and RRTMGP), CMEPS, documentation and CI #619

Merged
merged 123 commits into from
Jul 12, 2021

Conversation

MinsukJi-NOAA
Copy link
Contributor

@MinsukJi-NOAA MinsukJi-NOAA commented Jun 4, 2021

PR Checklist

  • Ths PR is up-to-date with the top of all sub-component repositories except for those sub-components which are the subject of this PR. Please consult the ufs-weather-model wiki if you are unsure how to do this.

  • This PR has been tested using a branch which is up-to-date with the top of all sub-component repositories except for those sub-components which are the subject of this PR

  • An Issue describing the work contained in this PR has been created either in the subcomponent(s) or in the ufs-weather-model. The Issue should be created in the repository that is most relevant to the changes in contained in the PR. The Issue and the dependent sub-component PR
    are specified below.

  • If new or updated input data is required by this PR, it is clearly stated in the text of the PR.

Description

Issue(s) addressed

Testing

Initial tests on Hera against BL of 20210616

Failed tests for Intel:

cpld_control 001 (only RESTART/ufs.cpld.cpl.r.2016-10-04-00000.nc, expected)
cpld_decomp 003 (only RESTART/ufs.cpld.cpl.r.2016-10-04-00000.nc, expected)
cpld_ca 004 (only RESTART/ufs.cpld.cpl.r.2016-10-04-00000.nc, expected)
cpld_control_c192 005 (only RESTART/ufs.cpld.cpl.r.2016-10-05-00000.nc, expected)
cpld_control_c384 007 (only RESTART/ufs.cpld.cpl.r.2016-10-03-43200.nc, expected)
cpld_bmark_v16 009 (only RESTART/ufs.cpld.cpl.r.2013-04-01-21600.nc, expected)
cpld_bmark_v16_nsst 011 (only RESTART/ufs.cpld.cpl.r.2013-04-01-21600.nc, expected)
cpld_bmark_wave_v16 012 (only RESTART/ufs.cpld.cpl.r.2013-04-01-21600.nc, expected)
cpld_bmark_wave_v16_noahmp 013 (also in Dom's testing)
cpld_control_wave 014 (only RESTART/ufs.cpld.cpl.r.2016-10-04-00000.nc, expected)
cpld_debug 015 (only RESTART/ufs.cpld.cpl.r.2016-10-03-21600.nc, expected)

control_rrtmgp 030 (also in Dom's testing)
control_thompson 036 (also in Dom's testing)
control_thompson_no_aero 037 (also in Dom's testing)

regional_quilt_RRTMGP 045 (also in Dom's testing)

fv3_gsd 046 (also in Dom's testing)
fv3_rrfs_v1alpha 047 (also in Dom's testing)
fv3_HAFS_v0_hwrf_thompson 051 (also in Dom's testing)
fv3_esg_HAFS_v0_hwrf_thompson 052 (also in Dom's testing)

control_rrtmgp_debug 061 (also in Dom's testing)
control_thompson_extdiag_debug 068 (MISSING baseline)
fv3_rrfs_v1alpha_debug 073 (also in Dom's testing)

datm_control_cfsr 076 (only RESTART/DATM_CFSR.cpl.r.2011-10-02-00000.nc, expected)
datm_control_gefs 078 (only RESTART/DATM_GEFS.cpl.r.2011-10-02-00000.nc, expected)
datm_bulk_cfsr 079 (only RESTART/DATM_CFSR.cpl.r.2011-10-02-00000.nc, expected)
datm_bulk_gefs 080 (only RESTART/DATM_GEFS.cpl.r.2011-10-02-00000.nc, expected)
datm_mx025_cfsr 081 (only RESTART/DATM_CFSR.cpl.r.2011-10-02-00000.nc, expected)
datm_mx025_gefs 082 (only RESTART/DATM_GEFS.cpl.r.2011-10-02-00000.nc, expected)
datm_debug_cfsr 083 (only RESTART/DATM_CFSR.cpl.r.2011-10-01-21600.nc, expected)
datm_cdeps_control_cfsr 084 (only RESTART/DATM_CFSR.cpl.r.2011-10-02-00000.nc, expected)
datm_cdeps_control_gefs 086 (only RESTART/DATM_GEFS.cpl.r.2011-10-02-00000.nc, expected)
datm_cdeps_bulk_cfsr 087 (only RESTART/DATM_CFSR.cpl.r.2011-10-02-00000.nc, expected)
datm_cdeps_bulk_gefs 088 (only RESTART/DATM_GEFS.cpl.r.2011-10-02-00000.nc, expected)
datm_cdeps_mx025_cfsr 089 (only RESTART/DATM_CFSR.cpl.r.2011-10-02-00000.nc, expected)
datm_cdeps_mx025_gefs 090 (only RESTART/DATM_GEFS.cpl.r.2011-10-02-00000.nc, expected)
datm_cdeps_multiple_files_cfsr 091 (only RESTART/DATM_CFSR.cpl.r.2011-10-02-00000.nc, expected)
datm_cdeps_debug_cfsr 092 (only RESTART/DATM_CFSR.cpl.r.2011-10-01-21600.nc, expected)

Failed tests for Gnu:

control_rrtmgp 005 (also in Dom's testing)
fv3_rrfs_v1alpha 011
fv3_rrfs_v1alpha_debug 017
control_thompson_extdiag_debug 022 (MISSING baseline)
control_rrtmgp_debug 023 (also in Dom's testing)

cpld_control 028 (only RESTART/ufs.cpld.cpl.r.2016-10-04-00000.nc, expected)
cpld_debug 029 (only RESTART/ufs.cpld.cpl.r.2016-10-03-21600.nc, expected)

Initial CI tests

All passed: https://github.com/ufs-community/ufs-weather-model/actions/runs/1005274763

Final tests

Dependencies

DeniseWorthen and others added 30 commits March 27, 2021 12:30
This reverts commit 7b826d4.
… Limit Jacobian Flux adjustment to below 100hPa.
@DeniseWorthen DeniseWorthen mentioned this pull request Jul 9, 2021
14 tasks
Copy link
Collaborator

@climbfuji climbfuji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just to confirm, you reverted my temporary change in tests/fv3_conf/control_run.IN and added the new diag table diag_table_gfsv16_thompson_extdiag to the current input data set? If so, thanks for catching that from the notes in my PR!

@DeniseWorthen
Copy link
Collaborator

@climbfuji The diag_table fix was was done at 2b0ae64

@climbfuji climbfuji self-requested a review July 12, 2021 14:49
Copy link
Collaborator

@climbfuji climbfuji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for incorporating all my changes and testing them while I was on leave.

@MinsukJi-NOAA MinsukJi-NOAA merged commit 3b8bb78 into ufs-community:develop Jul 12, 2021
@MinsukJi-NOAA MinsukJi-NOAA deleted the feature/ci-control branch July 12, 2021 17:44
epic-cicd-jenkins pushed a commit that referenced this pull request Apr 17, 2023
…t tasks into two) (#618)

1. Rename verification tasks and corresponding j-jobs, ex-scripts, and log files as described in issue #619.

2. Separate combined METplus vx tasks for surface and upper air into separate tasks. This is so that there is only one call to a METplus tool per ROCOTO task and helps simplify the workflow and debugging.

3. Ensure that each vx task has a separate section in config_defaults.yaml with its own resource variables (WTIME_..., PPN_..., etc).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Baseline Updates Current baselines will be updated.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants