8.2.2-3.11 - RUC implementation as a submodule #127
Conversation
In the modified code, soil resistance can completely turn off the evaporation with values of soil moisture close to minimum values. Thus, this change will help with moist bias in MPAS in the dry regions.
1. Created a new directory: physics_lsm_ruc 2. Moved RUC LSM subroutines to the new directory 3. Removed RUC LSM subroutines from physics_wrf. 4. Updated Makefiles in physics and physics_wrf directories. The new code compiled successfully.
…module The differences are only in the form of the model, but the same physics.
clark-evans
requested review from
barlage,
joeolson42,
haiqinli,
mdtoyNOAA and
AndersJensen-NOAA
|
Looks good to me. I see that the parameter tables are added to the MPAS directory. Is the intention that these are the tables that will be used by MPAS when RUC is active? In general, I think this is a good idea to keep the model-specific parameters in the model submodule, but I'm assuming additional changes would be needed to use these directly. |
Yes, the tables are saved in the MPAS directory for reference. At this point they are not used, because the general MPAS tables located in src/core_atmosphere/physics/physics_wrf/files/ are used. |
There was a problem hiding this comment.
Code looks good, though I'm curious about the convection_permitting_none test outputs - the 12-min and 60-min outputs are blank. Is this to be expected? @tanyasmirnova @barlage
|
@tanyasmirnova I forgot about the cmake build compatibility. See the discussion in #124 and #90 |
@clark-evans The convection_permitting_none suite is still failing until #116 gets merged so there is no output file to compare. @tanyasmirnova was ahead of the curve and is using the updated mpas_testcase |
Ah, yes, thanks. That's what I get for multitasking. |
@barlage Thank you, Mike. I added RUCLSM submodule to the CMakeLists.txt |
|
@tanyasmirnova if you want to test the cmake build you can use these commands on jet from the MPAS-Model directory: |
Mike, I followed your instructions and found a few issues in CMakLists.txt. I fixed them. The build directory is in /mnt/lfs5/BMC/wrfruc/smirnova/MPAS_code/MPAS_12may25_rucmod/build. |
tanyasmirnova
changed the title
The title above should be a 1 line short summary of the pull request (i.e. what the project the PR represents is intended to do).
RUC LSM implementation as a submodule.
RUC submodule is located in https://github.com/NOAA-GSL/RUCLSM.git.
It has RUC LSM versions of the code for MPAS, CCPP and WRF.
Testing and relations to other Pull Requests should be added as subsequent comments.
Information on running mandatory regression tests on Jet can be found here and the results pasted below.
All tests cases are identical, see in /mnt/lfs5/BMC/wrfruc/smirnova/MPAS_regression_tests/mpas_testcase/utils/compare_run_testcases_final_v8.2.2-3.11-intdebug
regression test case results