changes to fix the convection permitting suite #116
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
barlage
changed the title
clark-evans
requested review from
joeolson42,
haiqinli,
tanyasmirnova,
mdtoyNOAA and
AndersJensen-NOAA
joeolson42
approved these changes
May 12, 2025
clark-evans
approved these changes
May 12, 2025
mdtoyNOAA
approved these changes
May 13, 2025
tanyasmirnova
approved these changes
May 13, 2025
haiqinli
approved these changes
May 13, 2025
|
@AndersJensen-NOAA Looks like that one last Note that I've also added two more tests for a suite called |
AndersJensen-NOAA
requested changes
May 14, 2025
AndersJensen-NOAA
approved these changes
May 14, 2025
|
@clark-evans I reran the tests after code updates due to Anders' comments and still no answer changes. I think it's ready for merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Nested case statements were causing an issue with allocation of arrays necessary for Thompson microphysics. This cleans up the case statements, preserving the NCAR code and extending for TEMPO and NSSL MP. Because GF convection code is changed, we won't be able to reproduce NCAR suite so a new test will be proposed.
In addition, a few other things are added (may be bugs):
Addresses #75
No answer changes to the existing tests, but the convection permitting test will now run. TBD what we should compare it to since GF is changed from the NCAR version.
regression test case results