Skip to content

8.2.2-2.11 Correct initialization of snow on sea ice. #105

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Mar 26, 2025
Merged

8.2.2-2.11 Correct initialization of snow on sea ice. #105

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
4d1652a
Removed land/water masking in snow interpolation. This fix is needed to
tanyasmirnova Mar 3, 2025
33bb917
Limit snow depth on sea ice to 40 cm (120 mm SWE).
tanyasmirnova Mar 6, 2025
7ee9cc3
Merge branch 'NOAA-GSL:gsl/develop' into snowinit_bugfix
tanyasmirnova Mar 14, 2025
9a9bab5
In mpas_atmphys_initialize_real.F increase the limit of snow on ice to
tanyasmirnova Mar 14, 2025
cbd2bbd
Version is changed to 8.2.2-2.11
tanyasmirnova Mar 18, 2025
b2268c6
Merge branch 'gsl/develop' into snowinit_bugfix
jderrico-noaa Mar 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
MPAS-v8.2.2-2.10
MPAS-v8.2.2-2.11

The Model for Prediction Across Scales (MPAS) is a collaborative project for
developing atmosphere, ocean, and other earth-system simulation components for
Expand Down
3 changes: 2 additions & 1 deletion src/core_atmosphere/Registry.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
<?xml version="1.0"?>
<registry model="mpas" core="atmosphere" core_abbrev="atm" version="8.2.2-2.10">
<registry model="mpas" core="atmosphere" core_abbrev="atm" version="8.2.2-2.11">


<!-- **************************************************************************************** -->
<!-- ************************************** Dimensions ************************************** -->
Expand Down
7 changes: 7 additions & 0 deletions src/core_atmosphere/physics/mpas_atmphys_initialize_real.F
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -943,6 +943,7 @@ subroutine physics_init_seaice(mesh, input, dims, configs)
real(kind=RKIND),dimension(:),pointer :: vegfra
real(kind=RKIND),dimension(:),pointer :: seaice,snoalb,xice
real(kind=RKIND),dimension(:),pointer :: skintemp,tmn,xland
real(kind=RKIND),dimension(:),pointer :: snow, snowh
real(kind=RKIND),dimension(:,:),pointer:: tslb,smois,sh2o,smcrel

logical, pointer :: config_frac_seaice
Expand Down Expand Up @@ -979,6 +980,9 @@ subroutine physics_init_seaice(mesh, input, dims, configs)
call mpas_pool_get_array(input, 'tmn', tmn)
call mpas_pool_get_array(input, 'xland', xland)

call mpas_pool_get_array(input, 'snow', snow)
call mpas_pool_get_array(input, 'snowh', snowh)

call mpas_pool_get_array(input, 'tslb', tslb)
call mpas_pool_get_array(input, 'smois', smois)
call mpas_pool_get_array(input, 'sh2o', sh2o)
Expand Down Expand Up @@ -1020,6 +1024,9 @@ subroutine physics_init_seaice(mesh, input, dims, configs)
vegfra(iCell) = 0._RKIND
xland(iCell) = 1._RKIND
seaice(iCell) = 1._RKIND
!top limit on snow depth on sea ice: 1.2 m or 360 mm swe
snowh(iCell) = min(snowh(iCell),1.2_RKIND)
snow(iCell) = min(snow(iCell),360._RKIND)

!... recalculate the soil temperature and soil moisture:
do iSoil = 1, nSoilLevels
Expand Down
3 changes: 1 addition & 2 deletions src/core_init_atmosphere/Registry.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
<?xml version="1.0"?>

<registry model="mpas" core="init_atmosphere" core_abbrev="init_atm" version="8.2.2-2.10">
<registry model="mpas" core="init_atmosphere" core_abbrev="init_atm" version="8.2.2-2.11">

<!-- **************************************************************************************** -->
<!-- ************************************** Dimensions ************************************** -->
Expand Down
8 changes: 4 additions & 4 deletions src/core_init_atmosphere/mpas_init_atm_cases.F
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6131,8 +6131,8 @@ subroutine init_atm_case_gfs(block, mesh, nCells, nEdges, nVertLevels, fg, state
interp_list(2) = W_AVERAGE4
interp_list(3) = 0

masked = 0
fillval = 0.0
!masked = 0
!fillval = 0.0

nInterpPoints = nCells
latPoints => latCell
Expand All @@ -6146,8 +6146,8 @@ subroutine init_atm_case_gfs(block, mesh, nCells, nEdges, nVertLevels, fg, state
interp_list(2) = W_AVERAGE4
interp_list(3) = 0

masked = 0
fillval = 0.0
!masked = 0
!fillval = 0.0

nInterpPoints = nCells
latPoints => latCell
Expand Down