8.2.2-2.11 Correct initialization of snow on sea ice. #105
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
preserve initialized from GFS snow on sea ice. If some water points will get snow after horizontal interpolation, it will be cleaned out later in the model.
jderrico-noaa
requested review from
barlage,
joeolson42,
haiqinli,
mdtoyNOAA,
AndersJensen-NOAA and
clark-evans
clark-evans
reviewed
Mar 10, 2025
tanyasmirnova
changed the title
clark-evans
approved these changes
Mar 18, 2025
joeolson42
approved these changes
Mar 19, 2025
haiqinli
approved these changes
Mar 20, 2025
|
@tanyasmirnova There aren't any changes to the atmosphere_model so there aren't any changes in the run tests, but there should be changes in the init files, correct? The reported tests should include the init_atmosphere testing (create test) as well. |
@barlage Mike, yes the model runs are identical. The initial conditions for snow on sea ice will change. Not a big difference on our conus domain, maybe only the winter case. |
mdtoyNOAA
approved these changes
Mar 26, 2025
AndersJensen-NOAA
approved these changes
Mar 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The title above should be a 1 line short summary of the pull request (i.e. what the project the PR represents is intended to do).
Enter a description of this PR. This should include why this PR was created, and what it does.
1. Removed land/water masking in snow interpolation. This fix is needed to
keep GFS snow on sea ice. If some water points will get non-zero snow after horizontal interpolation, it
will be anyway cleaned out later in the model.
2. Limit initial snow ice to 1.2 m.
Testing and relations to other Pull Requests should be added as subsequent comments.
See the below examples for more information.
MPAS-Dev/MPAS#930
MPAS-Dev/MPAS#931
Information on running mandatory regression tests on Jet can be found here and the results pasted below.
This PR is tested against version 8.2.2-2.8, and all suites have identical results because the situation with snow on sea ice was not presented in our test cases.
The comparison results are in /mnt/lfs5/BMC/wrfruc/smirnova/MPAS_regression_tests/mpas_testcase/utils/compare_run_testcases_v8.2.2-2.11-intdebug
regression test case results