Merged
Conversation
amadulhaxxani
commented
Oct 31, 2025
- adding expand and collapse functionality when item is truncated
- showing the title (communities) as hierarchical structure e.g., test1 > test2 > test3
adding two new icons for expanding and collapsing description
added tests for new icons added in truncatable comp
creating the hierarchical structure for title
resolving the title test as now changed to hierarchical
removing unnecessary code
removed extra line
There was a problem hiding this comment.
Pull Request Overview
This PR adds hierarchical parent display and expandable truncation functionality to sidebar search list elements. The changes enable showing the complete parent hierarchy (e.g., "Root > SubCommunity > Parent") instead of just the immediate parent, and adds toggle icons to expand/collapse truncated text when no ID is available.
- Replaces single parent title with complete hierarchical parent chain using recursive traversal
- Adds new
noIdExpandablemode to truncatable parts with expand/collapse icons - Implements expand/collapse tracking for multiple truncatable components
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 13 comments.
Show a summary per file
| File | Description |
|---|---|
| truncatable-part.component.ts | Adds noIdExpandable input, truncated output event, and toggleWithoutId() method for ID-less expansion control |
| truncatable-part.component.spec.ts | Adds test coverage for new noIdExpandable property and toggleWithoutId() method |
| truncatable-part.component.html | Conditionally hides standard expand/collapse buttons when noIdExpandable is true |
| sidebar-search-list-element.component.ts | Implements hierarchical parent traversal, manages truncation state of multiple components, and adds expand/collapse toggle functionality |
| sidebar-search-list-element.component.spec.ts | Updates mock setup to support recursive parent resolution during testing |
| sidebar-search-list-element.component.html | Adds noIdExpandable binding, truncation event handlers, and expand/collapse icons |
src/app/shared/truncatable/truncatable-part/truncatable-part.component.html
Outdated
Show resolved
Hide resolved
src/app/shared/object-list/sidebar-search-list-element/sidebar-search-list-element.component.ts
Show resolved
Hide resolved
src/app/shared/object-list/sidebar-search-list-element/sidebar-search-list-element.component.ts
Outdated
Show resolved
Hide resolved
...pp/shared/object-list/sidebar-search-list-element/sidebar-search-list-element.component.html
Outdated
Show resolved
Hide resolved
...pp/shared/object-list/sidebar-search-list-element/sidebar-search-list-element.component.html
Outdated
Show resolved
Hide resolved
src/app/shared/object-list/sidebar-search-list-element/sidebar-search-list-element.component.ts
Outdated
Show resolved
Hide resolved
src/app/shared/truncatable/truncatable-part/truncatable-part.component.spec.ts
Outdated
Show resolved
Hide resolved
src/app/shared/truncatable/truncatable-part/truncatable-part.component.spec.ts
Outdated
Show resolved
Hide resolved
src/app/shared/truncatable/truncatable-part/truncatable-part.component.spec.ts
Outdated
Show resolved
Hide resolved
src/app/shared/truncatable/truncatable-part/truncatable-part.component.spec.ts
Outdated
Show resolved
Hide resolved
removing the flex row form truncatable component
adding a class with ng-deep
copilot fixes
copilot fixes
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 7 out of 7 changed files in this pull request and generated 5 comments.
Comments suppressed due to low confidence (1)
src/app/shared/object-list/sidebar-search-list-element/sidebar-search-list-element.component.ts:1
- The parameter 'expand' lacks a type annotation. Add explicit type annotation 'expand: boolean' for better type safety and code clarity.
import { SearchResult } from '../../search/models/search-result.model';
src/app/shared/object-list/sidebar-search-list-element/sidebar-search-list-element.component.ts
Outdated
Show resolved
Hide resolved
src/app/shared/truncatable/truncatable-part/truncatable-part.component.spec.ts
Outdated
Show resolved
Hide resolved
src/app/shared/truncatable/truncatable-part/truncatable-part.component.spec.ts
Show resolved
Hide resolved
...pp/shared/object-list/sidebar-search-list-element/sidebar-search-list-element.component.html
Outdated
Show resolved
Hide resolved
...pp/shared/object-list/sidebar-search-list-element/sidebar-search-list-element.component.html
Outdated
Show resolved
Hide resolved
src/app/shared/object-list/sidebar-search-list-element/sidebar-search-list-element.component.ts
Outdated
Show resolved
Hide resolved
copilot and other's fixes
src/app/shared/object-list/sidebar-search-list-element/sidebar-search-list-element.component.ts
Outdated
Show resolved
Hide resolved
src/app/shared/object-list/sidebar-search-list-element/sidebar-search-list-element.component.ts
Outdated
Show resolved
Hide resolved
src/app/shared/object-list/sidebar-search-list-element/sidebar-search-list-element.component.ts
Outdated
Show resolved
Hide resolved
removing the timeouts as not needed and the redundant code
optimizing code by using correct terminology and code usage
adding setTimeout to defer the change detection to next loop
src/app/shared/truncatable/truncatable-part/truncatable-part.component.ts
Outdated
Show resolved
Hide resolved
src/app/shared/truncatable/truncatable-part/truncatable-part.component.ts
Outdated
Show resolved
Hide resolved
src/app/shared/truncatable/truncatable-part/truncatable-part.component.ts
Outdated
Show resolved
Hide resolved
src/app/shared/object-list/sidebar-search-list-element/sidebar-search-list-element.component.ts
Show resolved
Hide resolved
copilot fixes
copilot fixes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.