Skip to content

Cross platform and basic config support #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jan 21, 2022

Conversation

gplsteph
Copy link
Contributor

  • Added the ability to define a publish area for publish hooks, if a publish template is not set, to support basic configs.
  • Allowed user settings to be saved and restored in publish hooks.
  • Added a workaround for processing Qt events on other platforms than Windows, which does not need it.
  • Fixed legacy Sequencer render command line to make it cross platform: spaces are perfectly well handled by subprocess.call without any need to protect the strings, if using a list for the call.
  • Fixed UE5.0EA discovery for other platforms than Windows.
  • Disabled things which make Unreal crash or which are not fully working.

gplsteph and others added 4 commits December 7, 2021 18:03
Allowed the publish hooks to be used with a basic config and only a publish template.
Added some UI to choose the root of publishes if the publish template is a string template.
Allowed settings to be saved and restored.
- Added a workaround for processing Qt events on other platforms than Windows, which does not need it.
- Fixed legacy Sequencer render command line to make it cross platform: spaces are perfectly well handled by subprocess.call without any need to protect the strings, if using a list for the call.
- Fixed UE5.0EA discovery for other platforms than Windows.
Disabled things which make Unreal crash or which are not fully working.
Copy link

@000paradox000 000paradox000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ryanmayeda ryanmayeda merged commit 42250cb into ue4plugins:gpltech Jan 21, 2022
ryanmayeda pushed a commit that referenced this pull request Apr 29, 2022
Added a script to update an existing default2 config with the Unreal integration.
Added supporting files to update an existing default2 config with the Unreal integration.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants