Skip to content

Compatibility with ue5.0.0 #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

OlivierArgentieri
Copy link

Tested with Unreal 5.0.0 official release.

Problem

Many errors when trying to launch unreal with tk-unreal bootstrap for Unreal 5.0.0
Maybe some Shotgun plugins classes and methods has been renamed to Shotgrid, and we need to update tk-unreal configuration ?

Changes

plugins/basic/python/tk_unreal_basic/plugin_bootstrap.py :

  • rename ShotgunEngine call to ShotgridEngine

python/tk_unreal/unreal_sg_engine.py:

  • rename class and inheritance ShotgunEngineWrapper to ShotgridEngineWrapper
  • rename overrided function get_shotgun_menu_items to get_shotgrid_menu_items
  • rename unreal.ShotgunMenuItem() to unreal.ShotgridMenuItem()

plugins/basic/bootstrap.py:

  • Workaround to use sgtk python module in Unreal Engine editor, need help/review on this part, because i'm not able to import sgtk in unreal without this.

Thank you

ryanmayeda pushed a commit that referenced this pull request Apr 29, 2022
- Added a workaround for processing Qt events on other platforms than Windows, which does not need it.
- Fixed legacy Sequencer render command line to make it cross platform: spaces are perfectly well handled by subprocess.call without any need to protect the strings, if using a list for the call.
- Fixed UE5.0EA discovery for other platforms than Windows.
@ryanmayeda
Copy link
Collaborator

Hi Olivier, apologies for not seeing this sooner. We were working on updates for UE5 and I just pushed them on Friday. Can you try the latest tag? There are also some updates to the configs and the shot publish hook from UE now uses Movie Render Queue instead of the legacy Sequencer rendering. I think our changes should cover this pull request.

@OlivierArgentieri
Copy link
Author

Hi,
Thank you for your reply !
No worries I settled the conflicts only to see the modifications made on the last tag and all the modifications requested in this pull request have been added. 👍
The new version also fixes the problem I had with the workaround, so i can close this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants