bug fix

annotator-core/src/test/java/edu/ucr/cs/riple/core/DownstreamAnalysisTest.java

@@ -78,13 +78,13 @@ public void publicMethodWithDownstreamDependencyDisabled() {
   public void lowerBoundComputationTest() {
     coreTestHelper
         .addExpectedReports(
-            // Only returnNullableBad triggers new errors in this fix chain (+9), lower bound is 9.
-            new TReport(new OnMethod("Foo.java", "test.target.Foo", "returnNullableBad(int)"), 9),
+            // Only returnNullableBad triggers new errors in this fix chain (+9), lower bound is 10.
+            new TReport(new OnMethod("Foo.java", "test.target.Foo", "returnNullableBad(int)"), 10),
             // Only returnNullableGood triggers new errors in this fix chain (+1), lower bound is 1.
             new TReport(new OnMethod("Foo.java", "test.target.Foo", "returnNullableGood(int)"), 1),
             // Root fix triggers 1 error on downstream dependency but returnNullableBad is
-            // present in the fix tree, therefore the lower bound effect for the tree should be 9.
-            new TReport(new OnMethod("Foo.java", "test.target.Foo", "bar()"), 9))
+            // present in the fix tree, therefore the lower bound effect for the tree should be 10.
+            new TReport(new OnMethod("Foo.java", "test.target.Foo", "bar()"), 10))
         .setPredicate(
             (expected, found) ->
                 expected.root.equals(found.root)
@@ -100,16 +100,16 @@ public void lowerBoundComputationTest() {
   public void upperBoundComputationTest() {
     coreTestHelper
         .addExpectedReports(
-            // Only returnNullableBad triggers new errors in this fix chain (+9) and upper bound
-            // should be 9
-            new TReport(new OnMethod("Foo.java", "test.target.Foo", "returnNullableBad(int)"), 9),
+            // Only returnNullableBad triggers new errors in this fix chain (+10) and upper bound
+            // should be 10
+            new TReport(new OnMethod("Foo.java", "test.target.Foo", "returnNullableBad(int)"), 10),
             // Only returnNullableGood triggers new errors in this fix chain (+1) and upper bound
             // should be 1
             new TReport(new OnMethod("Foo.java", "test.target.Foo", "returnNullableGood(int)"), 1),
             // Root fix triggers 1 error on downstream dependency and returnNullableBad is
-            // present in the fix tree and triggers 9 errors on downstream dependency, therefore the
-            // upper bound effect for the tree should be 10.
-            new TReport(new OnMethod("Foo.java", "test.target.Foo", "bar()"), 10))
+            // present in the fix tree and triggers 10 errors on downstream dependency, therefore the
+            // upper bound effect for the tree should be 11.
+            new TReport(new OnMethod("Foo.java", "test.target.Foo", "bar()"), 11))
         .setPredicate(
             (expected, found) ->
                 expected.root.equals(found.root)

annotator-core/src/test/resources/templates/downstream-dependency-test/Target/src/main/java/test/target/Foo.java

@@ -25,9 +25,8 @@
 public class Foo {
   Object field = new Object();
 
-  // Making this method will resolve 5 errors here and will introduce 1 new error here and 8 new
+  // Making this method will resolve 5 errors here and will introduce 1 new error here and 10 new
   // errors on downstream dependencies.
-  // dependencies.
   public Object returnNullableBad(int i) {
     // Just to create 5 places where it returns nullable, so making this method @Nullable will
     // resolve 5 NullAway errors