-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add @NullUnmarked on classes #134
Merged
Merged
Changes from 1 commit
Commits
Show all changes
47 commits
Select commit
Hold shift + click to select a range
d465eda
init
nimakarimipour 2e8e65f
update
nimakarimipour 46d84ac
undo unwanted change
nimakarimipour 1fba197
update
nimakarimipour 3e2e8b4
update
nimakarimipour 2bf6459
update
nimakarimipour 70bf1ef
move to proper position
nimakarimipour 6046ebf
update
nimakarimipour f98fc55
update
nimakarimipour fc41c67
undo deleted comment
nimakarimipour c201245
Update annotator-core/src/main/java/edu/ucr/cs/riple/core/Annotator.java
nimakarimipour da8c98a
reformat
nimakarimipour 64d8c57
keep file path info for class with no fields as well
nimakarimipour 47998c0
update unit test
nimakarimipour 01c679a
remove print statement
nimakarimipour 8a517d0
prevent constructor @NullUnmarked for constructors
nimakarimipour 8c2c3ae
Merge branch 'nimak/resolve-remaining' into nimak/nullunmarked-class
nimakarimipour 6b49f66
merge with nimak/force-resolve
nimakarimipour fcd2fe6
add comment
nimakarimipour ab8d201
Merge branch 'nimak/resolve-remaining' into nimak/nullunmarked-class
nimakarimipour 5f25f1b
update unit test
nimakarimipour 27a2535
update nullaway test version
nimakarimipour 0d630c6
Merge branch 'nimak/resolve-remaining' into nimak/update-nullaway
nimakarimipour b27c14a
Merge branch 'master' into nimak/resolve-remaining
nimakarimipour 79b11b1
Merge branch 'nimak/resolve-remaining' into nimak/update-nullaway
nimakarimipour 2b13142
Merge branch 'master' into nimak/update-nullaway
nimakarimipour 4f18e80
fix bug
nimakarimipour 9b729e8
bug fix
nimakarimipour dcf81b4
reformat
nimakarimipour 0550bb5
update unit test expected values
nimakarimipour 15fbbd4
Merge branch 'master' into nimak/nullunmarked-class
nimakarimipour 9798ca4
Merge branch 'nimak/update-nullaway' into nimak/nullunmarked-class
nimakarimipour 084e9e6
update
nimakarimipour cafef18
rename to init block
nimakarimipour 139c19a
remove import from unit test input
nimakarimipour 1f39e96
Merge branch 'master' into nimak/nullunmarked-class
nimakarimipour a811889
remove import from unit test input
nimakarimipour 71b998b
add unit test for named inner classes
nimakarimipour 4fb60f1
add unit test for named inner classes
nimakarimipour 344007b
rename test
nimakarimipour 45374b8
Merge branch 'master' into nimak/update-nullaway
nimakarimipour 3e1bb7c
Update annotator-core/src/main/java/edu/ucr/cs/riple/core/metadata/tr…
nimakarimipour 3a43655
Update annotator-core/src/main/java/edu/ucr/cs/riple/core/metadata/tr…
nimakarimipour ca510cc
Merge branch 'nimak/update-nullaway' into nimak/nullunmarked-class
nimakarimipour 95429c8
merge master
nimakarimipour 4eb1bbe
Merge branch 'master' into nimak/nullunmarked-class
nimakarimipour 74e44b9
update comment
nimakarimipour File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
update unit test
- Loading branch information
commit 47998c01f5b1f7148818a15f711ba424ae84b3d9
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we want to test static initializer block support and instance initializer block in the same test? (if so, the test case might need renaming). Or is it perhaps better to have two separate test cases for ease of reading/debugging?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the decision for now is to have them in one test until #137 is finalized, therefore I renamed the test name 344007b