Basic coverage of migwsgi. #98
Conversation
albu-diku
force-pushed
the
fix/force-recursive-py3
branch
from
c64af9a to
ca47e01
Compare
albu-diku
force-pushed
the
test/migwsgi
branch
2 times, most recently
from
dd831a2 to
0b734fc
Compare
albu-diku
force-pushed
the
fix/force-recursive-py3
branch
from
a34927d to
a40a095
Compare
albu-diku
force-pushed
the
test/migwsgi
branch
from
0b734fc to
f3d8e5a
Compare
albu-diku
force-pushed
the
test/migwsgi
branch
2 times, most recently
from
ae69a06 to
f9859bd
Compare
albu-diku
force-pushed
the
test/migwsgi
branch
from
f9859bd to
988a0ed
Compare
albu-diku
force-pushed
the
test/migwsgi
branch
3 times, most recently
from
ffa18a4 to
38b00ac
Compare
albu-diku
force-pushed
the
test/migwsgi
branch
2 times, most recently
from
3bfa12b to
584464f
Compare
|
Made a final attempt to add some coverage. I have clearly clearly stated the PR dependencies, which leaves one single commit. From this, I removed basically every change that could be deemed refactoring but was also a source of fear about behaviour change. Any less is not possible and the vast majority of the PR is test code now. |
albu-diku
force-pushed
the
test/migwsgi
branch
from
584464f to
a17001f
Compare
albu-diku
force-pushed
the
test/migwsgi
branch
2 times, most recently
from
40cb471 to
af91424
Compare
albu-diku
force-pushed
the
test/migwsgi
branch
from
af91424 to
6a6add4
Compare
There was a problem hiding this comment.
Looks good and importantly rather careful about not changing any existing code, as we talked about off list 👍 so I'll go ahead with merging despite the pedantic to minor format issues in my comments.
In terms of the practical merge, I'm not sure if I can actually merge directly in next without causing issues for the sync with our backwards compatible experimental branch name. So I may have to effectively merge there and only rebase into next afterwards as we do for other PRs. Time will tell.
albu-diku
force-pushed
the
test/migwsgi
branch
2 times, most recently
from
5b421f9 to
ff85267
Compare
This PR does the principle things required to allow exercising the central component responsible for glueing named MiG "functionality" files to WSGI. Included is a new wsgisupp.py file implementing the support bits to allow exercising WSGI related code in a readable way.
albu-diku
force-pushed
the
test/migwsgi
branch
from
ff85267 to
e48b12e
Compare
|
Merged through |
This PR does the principle things required to allow exercising the
central component responsible for glueing named MiG "functionality"
files to WSGI. Includde is a new wsgisupp.py file that implements
support code allowing exercising WSGI handlers in a readable way.