Regression test for valid HTML being generated in the error path. #182
Conversation
albu-diku
force-pushed
the
test/migwsgi
branch
3 times, most recently
from
af91424 to
6a6add4
Compare
albu-diku
force-pushed
the
test/migwsgi
branch
3 times, most recently
from
ff85267 to
e48b12e
Compare
|
I wonder what happened here with all those commits and apparently unrelated files changed? |
albu-diku
force-pushed
the
test/invalid-html-on-error
branch
from
a8582b9 to
b0a3f93
Compare
|
I’m not sure exactly what happened here either. Unfortunately we also landed something a bit different to what this was sat atop so it had also bitrotted - I’ve rewritten the validating assertion along the lines of the title checker and pushed it back up. |
| @@ -173,5 +226,46 @@ def test_return_value_ok_returns_expected_title(self): | |||
| self.assertHtmlTitle(output, title_text='TEST', trim_newlines=True) | |||
|
|
|||
|
|
|||
| class MigWsgibin_output_objects(MigTestCase, WsgiAssertMixin): | |||
|
|
|||
There was a problem hiding this comment.
I can see you even left room for the mandatory class docstring here ... ;-)
Apart from that pedantic bit the PR looks unintrusive enough for me to proceed with the merge as-is and leave adjustments to follow-up. Perhaps one or more methods/functions would also gain clarity from added docs.
jonasbardino
added this to the
Python3 support for general research data sites milestone
This PR is a test only addition that adds a regression test for the fix that landed as c545adc, the original PR being #178. The test was written at the same time as the original fix but has additional dependencies (#98). With the pre-requisite now in-tree we can now land this and address the follow-up item.