Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Save sample/patient-specific metapipeline logs #196

Merged
merged 8 commits into from
May 10, 2024
Merged

Conversation

zhuchcn
Copy link
Member

@zhuchcn zhuchcn commented May 6, 2024

This enables the sample/patient-specific nextflow logs to be saved, including trace.txt, report.html, and timeline.html.

Closes #187

  • I have read the code review guidelines and the code review best practice on GitHub check-list.

  • The name of the branch is meaningful and well formatted following the standards, using [AD_username (or 5 letters of AD if AD is too long)-[brief_description_of_branch].

  • I have set up or verified the branch protection rule following the github standards before opening this pull request.

  • I have added my name to the contributors listings in the
    metadata.yaml and the manifest block in the nextflow.config as part of this pull request, am listed
    already, or do not wish to be listed. (This acknowledgement is optional.)

  • I have added the changes included in this pull request to the CHANGELOG.md under the next release version or unreleased, and updated the date.

  • I have updated the version number in the metadata.yaml and manifest block of the nextflow.config file following semver, or the version number has already been updated. (Leave it unchecked if you are unsure about new version number and discuss it with the infrastructure team in this PR.)

  • I have tested the pipeline on at least one A-mini sample.

@zhuchcn zhuchcn requested a review from yashpatel6 May 6, 2024 22:09
@zhuchcn zhuchcn requested a review from yashpatel6 May 9, 2024 18:13
Copy link
Collaborator

@yashpatel6 yashpatel6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor suggestion but otherwise looks good!

CHANGELOG.md Outdated Show resolved Hide resolved
Co-authored-by: Yash Patel <86321070+yashpatel6@users.noreply.github.com>
@zhuchcn zhuchcn merged commit e8b5f29 into main May 10, 2024
5 checks passed
@zhuchcn zhuchcn deleted the czhu-fix-trace branch May 10, 2024 00:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Save sample level metapipline nextflow log
2 participants