-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Evan buzzfeed quiz edits #30
Merged
Merged
Changes from 1 commit
Commits
Show all changes
17 commits
Select commit
Hold shift + click to select a range
f99cdc0
minor whitespace changes
evanzhong 1d09a1a
reduce complexity, place _bind into this.init directly
evanzhong 92e1296
encapsulate jQuery in getNumberCompleteAnswers to reduce complexity
evanzhong fac1bca
simplify this._calcResult
evanzhong 95f194d
rename .active class to .chosen
evanzhong ace6eea
this.init and this._pickAnswer renaming
evanzhong 1590131
encapsulate most of the this.init jQuery
evanzhong de7cfb6
encapsulate jQuery logic out of this._calcResult
evanzhong b643fb2
this._showResult jQuery encapsulation
evanzhong 82a8140
make questions key a string to reduce ambiguity + magic code comment
evanzhong b7febef
edit comments for spelling
evanzhong 56db2cc
var => let
evanzhong af626ed
opt for /**/ comments
evanzhong 5ff4a36
init README
evanzhong 4987601
README dictionary refresher
evanzhong b1261b6
README questions data struct description
evanzhong 9876bb3
Update README.md
evanzhong File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
rename .active class to .chosen
- Loading branch information
commit 95f194d044c2478c434b52f4c006b069040c395b
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor renaming, makes certain lines read more like English such as:
let chosenAnswer = $(question).find('.quiz-answer.chosen').data('quiz-answer')