Evan buzzfeed quiz edits #30
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
evanzhong
commented
Dec 10, 2020
Comment on lines
+54
to
+55
| <!-- Magic things that make the quiz work behind the scenes! --> | ||
| <script src="http://ajax.googleapis.com/ajax/libs/jquery/1.7.1/jquery.min.js" type="text/javascript"></script> |
There was a problem hiding this comment.
We need to include this so when students copy our codepen the appropriate jQuery libraries are linked
evanzhong
commented
Dec 10, 2020
Comment on lines
+5
to
+10
| 'Q1': {'a':1,'b':2,'c':3,'d':4}, | ||
| 'Q2': {'a':2,'b':3,'c':4,'d':1}, | ||
| 'Q3': {'a':2,'b':4,'c':1,'d':3}, | ||
| 'Q4': {'a':3,'b':1,'c':2,'d':4}, | ||
| 'Q5': {'a':1,'b':2,'c':3,'d':4}, | ||
| 'Q6': {'a':1,'b':2,'c':3,'d':4} |
There was a problem hiding this comment.
I opted to change the top level keys here to strings 1 => Q1
It reduces some ambiguity and thus makes describing the different levels in our nested dictionary a little easier.
evanzhong
commented
Dec 10, 2020
| this.init = function(){ | ||
| self._bindEvents(); |
There was a problem hiding this comment.
I removed this function and just placed the code directly in the init function
evanzhong
commented
Dec 10, 2020
| @@ -41,7 +41,7 @@ body { | |||
| margin-right:10px; | |||
| } | |||
|
|
|||
| &.active { | |||
| &.chosen { | |||
There was a problem hiding this comment.
Minor renaming, makes certain lines read more like English such as:
let chosenAnswer = $(question).find('.quiz-answer.chosen').data('quiz-answer')
Edited for typos
|
Awesome work! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bunch of changes in preparation for project walkthrough with the kids.
Main focuses
script.jsto make reading it less overwhelming for studentsMinor focuses