-
Notifications
You must be signed in to change notification settings - Fork 6
Feat(events): add PullRequestReviewComment #13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
test comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @devtayls, great first-pass. Let's see how the feature looks, but I left one comment already on some of the functionality.
In addition, it looks like there are quite a few whitespace changes; is this from an extension you have in your editor/IDE? I'd prefer to not introduce any formatting changes at the moment (that is, until we bring back Prettier, etc.).
@mattxwang The whitespace changes were from the linter. When I tried to commit, it spit out errors. That's the change that I got from running the linter. I agree that it isn't best, and I can see if I can't do something to let the commit hook let me change the file without the white space changes |
Oh I see. In that case, don't worry about it; the hook must not be working on my end, so you're totally good. Feel free to leave those in! (I'll try to replicate, but |
@mattxwang Actually, I think it may be me after-all. I did have to run |
660c461
to
b962f57
Compare
b962f57
to
2be3cc6
Compare
Third times the charm! |
Hmm. I don't see anything when I check the event log in the staging build. @mattxwang Any ideas? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Currently, it seems like the feature doesn't work properly; left some extra comments. I think the issue that you've raised in #17 is introduced in this PR, so if you resolve it (and get it to work), then you should be good to go!
As a tip - it's always a good strategy to compare what's live (ex on main
) and what gets generated from your code. That way, you can see if regressions / features that you introduce are working!
Hmm. I don't see anything when I check the event log in the staging build. @mattxwang Any ideas?
Do you mean for Netlify? I think the preview has built properly. If you're unable to access it, try https://deploy-preview-13--opensource-acm-ucla.netlify.app/.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work @devtayls, testing on live I think this is good to merge. Thanks for all your back-and-forth on this issue!
(Going to tag this with hacktoberfest-accepted)
Resolves issue #10
Adds
PullRequestReviewComment
to the list of events inGithubEventAction.tsx