Skip to content

Feat(events): add PullRequestReviewComment #13

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Oct 17, 2021

Conversation

devtayls
Copy link
Contributor

@devtayls devtayls commented Oct 11, 2021

Resolves issue #10

Adds PullRequestReviewComment to the list of events in GithubEventAction.tsx

@devtayls
Copy link
Contributor Author

test comment

Copy link
Member

@mattxwang mattxwang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @devtayls, great first-pass. Let's see how the feature looks, but I left one comment already on some of the functionality.

In addition, it looks like there are quite a few whitespace changes; is this from an extension you have in your editor/IDE? I'd prefer to not introduce any formatting changes at the moment (that is, until we bring back Prettier, etc.).

@mattxwang
Copy link
Member

FYI, this is what I have on the deploy right now. Now that there are events returning from the API, you should be able to test this more rigorously!

Screen Shot 2021-10-10 at 9 31 39 PM

@devtayls
Copy link
Contributor Author

@mattxwang The whitespace changes were from the linter. When I tried to commit, it spit out errors. That's the change that I got from running the linter.

I agree that it isn't best, and I can see if I can't do something to let the commit hook let me change the file without the white space changes

@mattxwang
Copy link
Member

mattxwang commented Oct 11, 2021

@mattxwang The whitespace changes were from the linter. When I tried to commit, it spit out errors. That's the change that I got from running the linter.

I agree that it isn't best, and I can see if I can't do something to let the commit hook let me change the file without the white space changes

Oh I see. In that case, don't worry about it; the hook must not be working on my end, so you're totally good. Feel free to leave those in!

(I'll try to replicate, but yarn format and yarn lint give me nothing to work with)

@devtayls
Copy link
Contributor Author

@mattxwang Actually, I think it may be me after-all. I did have to run yarn lint -fix, but when I opened the file up in my IDE my editor made some changes. hurr durr. Sorry about that, I'll force push on top of it to fix that.

@devtayls devtayls force-pushed the feat/add-pr-comment-event branch from 660c461 to b962f57 Compare October 11, 2021 05:27
@devtayls devtayls force-pushed the feat/add-pr-comment-event branch from b962f57 to 2be3cc6 Compare October 11, 2021 05:33
@devtayls
Copy link
Contributor Author

Third times the charm!

@devtayls
Copy link
Contributor Author

Hmm. I don't see anything when I check the event log in the staging build. @mattxwang Any ideas?

Copy link
Member

@mattxwang mattxwang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Currently, it seems like the feature doesn't work properly; left some extra comments. I think the issue that you've raised in #17 is introduced in this PR, so if you resolve it (and get it to work), then you should be good to go!

As a tip - it's always a good strategy to compare what's live (ex on main) and what gets generated from your code. That way, you can see if regressions / features that you introduce are working!

Hmm. I don't see anything when I check the event log in the staging build. @mattxwang Any ideas?

Do you mean for Netlify? I think the preview has built properly. If you're unable to access it, try https://deploy-preview-13--opensource-acm-ucla.netlify.app/.

@devtayls devtayls requested a review from mattxwang October 17, 2021 19:07
@mattxwang mattxwang linked an issue Oct 17, 2021 that may be closed by this pull request
Copy link
Member

@mattxwang mattxwang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work @devtayls, testing on live I think this is good to merge. Thanks for all your back-and-forth on this issue!

(Going to tag this with hacktoberfest-accepted)

@mattxwang mattxwang merged commit 938f3a7 into uclaacm:main Oct 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Process PullRequestReviewCommentEvent properly
2 participants