Event truncation: Pull Request numbers not appearing in event log

[devtayls]

From a preview build of the application, I noticed that two events that did not contain a pull request number.

Clicking the links leads to:

https://api.github.com/repos/uclaacm/opensource/pulls/13

[mattxwang]

Hey @devtayls, I think that this is something introduced in your PR #13; I can't replicate this on live.

For example, on live:

Matching the same one on your deploy preview:

In other words, you should be able to resolve this in #13!

[mattxwang]

FYI, here is a dump (from the API endpoint) of the JSON object that has generated the above error; you may want to use it to troubleshoot what's going on!

{
    "id": "18373320467",
    "type": "PullRequestReviewCommentEvent",
    "actor": {
      "id": 14893287,
      "login": "mattxwang",
      "display_login": "mattxwang",
      "gravatar_id": "",
      "url": "https://api.github.com/users/mattxwang",
      "avatar_url": "https://avatars.githubusercontent.com/u/14893287?"
    },
    "repo": {
      "id": 364504742,
      "name": "uclaacm/opensource",
      "url": "https://api.github.com/repos/uclaacm/opensource"
    },
    "payload": {
      "action": "created",
      "comment": {
        "url": "https://api.github.com/repos/uclaacm/opensource/pulls/comments/725781147",
        "pull_request_review_id": 775795575,
        "id": 725781147,
        "node_id": "PRRC_kwDOFbnmps4rQoqb",
        "diff_hunk": "@@ -61,7 +77,24 @@ function GitHubEventAction({type, payload}: GitHubEventActionProps): JSX.Element\n       if (!action || !prNum || !prURL) {\n         return unknown;\n       }\n-      return <span>{action} <ELink link={prURL}>pull request #{prNum}</ELink> in</span>;\n+      return (\n+        <span>\n+          {action} <ELink link={prURL}>pull request #{prNum}</ELink> in\n+        </span>\n+      );\n+    }\n+    case 'PullRequestReviewComment': {\n+      const action = payload.action;\n+      const author = payload.comment.user.login;\n+      const authorLink = payload.comment.user.url;\n+      const prNum = payload.comment.number;\n+      const prLink = payload.comment.pull_request_url;\n+      return (\n+        <span>\n+          {action} by <ELink link={authorLink}>{author}</ELink> on{' '}\n+          <ELink link={prLink}> pull request #{prNum}</ELink> in\n+        </span>\n+      );",
        "path": "components/GitHubEventAction.tsx",
        "position": 85,
        "original_position": 85,
        "commit_id": "660c4610f8c332835e0777625cf7ba4b981b1d4a",
        "original_commit_id": "660c4610f8c332835e0777625cf7ba4b981b1d4a",
        "user": {
          "login": "mattxwang",
          "id": 14893287,
          "node_id": "MDQ6VXNlcjE0ODkzMjg3",
          "avatar_url": "https://avatars.githubusercontent.com/u/14893287?v=4",
          "gravatar_id": "",
          "url": "https://api.github.com/users/mattxwang",
          "html_url": "https://github.com/mattxwang",
          "followers_url": "https://api.github.com/users/mattxwang/followers",
          "following_url": "https://api.github.com/users/mattxwang/following{/other_user}",
          "gists_url": "https://api.github.com/users/mattxwang/gists{/gist_id}",
          "starred_url": "https://api.github.com/users/mattxwang/starred{/owner}{/repo}",
          "subscriptions_url": "https://api.github.com/users/mattxwang/subscriptions",
          "organizations_url": "https://api.github.com/users/mattxwang/orgs",
          "repos_url": "https://api.github.com/users/mattxwang/repos",
          "events_url": "https://api.github.com/users/mattxwang/events{/privacy}",
          "received_events_url": "https://api.github.com/users/mattxwang/received_events",
          "type": "User",
          "site_admin": false
        },
        "body": "You shouldn't need to specify the author; currently, the component that wraps `<GitHubEventAction />` (`<GitHubEvent />`) handles this logic!\r\n\r\n(that means you shouldn't need the `author` or `authorLink` fields).",
        "created_at": "2021-10-11T04:29:05Z",
        "updated_at": "2021-10-11T04:30:25Z",
        "html_url": "https://github.com/uclaacm/opensource/pull/13#discussion_r725781147",
        "pull_request_url": "https://api.github.com/repos/uclaacm/opensource/pulls/13",
        "author_association": "MEMBER",
        "_links": {
          "self": {
            "href": "https://api.github.com/repos/uclaacm/opensource/pulls/comments/725781147"
          },
          "html": {
            "href": "https://github.com/uclaacm/opensource/pull/13#discussion_r725781147"
          },
          "pull_request": {
            "href": "https://api.github.com/repos/uclaacm/opensource/pulls/13"
          }
        },
        "reactions": {
          "url": "https://api.github.com/repos/uclaacm/opensource/pulls/comments/725781147/reactions",
          "total_count": 0,
          "+1": 0,
          "-1": 0,
          "laugh": 0,
          "hooray": 0,
          "confused": 0,
          "heart": 0,
          "rocket": 0,
          "eyes": 0
        },
        "start_line": 86,
        "original_start_line": 86,
        "start_side": "RIGHT",
        "line": 97,
        "original_line": 97,
        "side": "RIGHT"
      },
      "pull_request": {
        "url": "https://api.github.com/repos/uclaacm/opensource/pulls/13",
        "id": 754894568,
        "node_id": "PR_kwDOFbnmps4s_sbo",
        "html_url": "https://github.com/uclaacm/opensource/pull/13",
        "diff_url": "https://github.com/uclaacm/opensource/pull/13.diff",
        "patch_url": "https://github.com/uclaacm/opensource/pull/13.patch",
        "issue_url": "https://api.github.com/repos/uclaacm/opensource/issues/13",
        "number": 13,
        "state": "open",
        "locked": false,
        "title": "Feat(events): add PullRequestReviewComment",
        "user": {
          "login": "devtayls",
          "id": 16793430,
          "node_id": "MDQ6VXNlcjE2NzkzNDMw",
          "avatar_url": "https://avatars.githubusercontent.com/u/16793430?v=4",
          "gravatar_id": "",
          "url": "https://api.github.com/users/devtayls",
          "html_url": "https://github.com/devtayls",
          "followers_url": "https://api.github.com/users/devtayls/followers",
          "following_url": "https://api.github.com/users/devtayls/following{/other_user}",
          "gists_url": "https://api.github.com/users/devtayls/gists{/gist_id}",
          "starred_url": "https://api.github.com/users/devtayls/starred{/owner}{/repo}",
          "subscriptions_url": "https://api.github.com/users/devtayls/subscriptions",
          "organizations_url": "https://api.github.com/users/devtayls/orgs",
          "repos_url": "https://api.github.com/users/devtayls/repos",
          "events_url": "https://api.github.com/users/devtayls/events{/privacy}",
          "received_events_url": "https://api.github.com/users/devtayls/received_events",
          "type": "User",
          "site_admin": false
        },
        "body": "Addresses issue #10 \r\n\r\nAdds `PullRequestReviewComment` to the list of events in `GithubEventAction.tsx` \r\n\r\n",
        "created_at": "2021-10-11T04:09:39Z",
        "updated_at": "2021-10-11T04:30:25Z",
        "closed_at": null,
        "merged_at": null,
        "merge_commit_sha": "8b1bf672d944e60e7b4178accad00185c5cceb7e",
        "assignee": null,
        "assignees": [

        ],
        "requested_reviewers": [

        ],
        "requested_teams": [

        ],
        "labels": [

        ],
        "milestone": null,
        "draft": false,
        "commits_url": "https://api.github.com/repos/uclaacm/opensource/pulls/13/commits",
        "review_comments_url": "https://api.github.com/repos/uclaacm/opensource/pulls/13/comments",
        "review_comment_url": "https://api.github.com/repos/uclaacm/opensource/pulls/comments{/number}",
        "comments_url": "https://api.github.com/repos/uclaacm/opensource/issues/13/comments",
        "statuses_url": "https://api.github.com/repos/uclaacm/opensource/statuses/660c4610f8c332835e0777625cf7ba4b981b1d4a",
        "head": {
          "label": "devtayls:feat/add-pr-comment-event",
          "ref": "feat/add-pr-comment-event",
          "sha": "660c4610f8c332835e0777625cf7ba4b981b1d4a",
          "user": {
            "login": "devtayls",
            "id": 16793430,
            "node_id": "MDQ6VXNlcjE2NzkzNDMw",
            "avatar_url": "https://avatars.githubusercontent.com/u/16793430?v=4",
            "gravatar_id": "",
            "url": "https://api.github.com/users/devtayls",
            "html_url": "https://github.com/devtayls",
            "followers_url": "https://api.github.com/users/devtayls/followers",
            "following_url": "https://api.github.com/users/devtayls/following{/other_user}",
            "gists_url": "https://api.github.com/users/devtayls/gists{/gist_id}",
            "starred_url": "https://api.github.com/users/devtayls/starred{/owner}{/repo}",
            "subscriptions_url": "https://api.github.com/users/devtayls/subscriptions",
            "organizations_url": "https://api.github.com/users/devtayls/orgs",
            "repos_url": "https://api.github.com/users/devtayls/repos",
            "events_url": "https://api.github.com/users/devtayls/events{/privacy}",
            "received_events_url": "https://api.github.com/users/devtayls/received_events",
            "type": "User",
            "site_admin": false
          },
          "repo": {
            "id": 415772762,
            "node_id": "R_kgDOGMgwWg",
            "name": "opensource",
            "full_name": "devtayls/opensource",
            "private": false,
            "owner": {
              "login": "devtayls",
              "id": 16793430,
              "node_id": "MDQ6VXNlcjE2NzkzNDMw",
              "avatar_url": "https://avatars.githubusercontent.com/u/16793430?v=4",
              "gravatar_id": "",
              "url": "https://api.github.com/users/devtayls",
              "html_url": "https://github.com/devtayls",
              "followers_url": "https://api.github.com/users/devtayls/followers",
              "following_url": "https://api.github.com/users/devtayls/following{/other_user}",
              "gists_url": "https://api.github.com/users/devtayls/gists{/gist_id}",
              "starred_url": "https://api.github.com/users/devtayls/starred{/owner}{/repo}",
              "subscriptions_url": "https://api.github.com/users/devtayls/subscriptions",
              "organizations_url": "https://api.github.com/users/devtayls/orgs",
              "repos_url": "https://api.github.com/users/devtayls/repos",
              "events_url": "https://api.github.com/users/devtayls/events{/privacy}",
              "received_events_url": "https://api.github.com/users/devtayls/received_events",
              "type": "User",
              "site_admin": false
            },
            "html_url": "https://github.com/devtayls/opensource",
            "description": "opensource @ acm (but for now, matt's playground)",
            "fork": true,
            "url": "https://api.github.com/repos/devtayls/opensource",
            "forks_url": "https://api.github.com/repos/devtayls/opensource/forks",
            "keys_url": "https://api.github.com/repos/devtayls/opensource/keys{/key_id}",
            "collaborators_url": "https://api.github.com/repos/devtayls/opensource/collaborators{/collaborator}",
            "teams_url": "https://api.github.com/repos/devtayls/opensource/teams",
            "hooks_url": "https://api.github.com/repos/devtayls/opensource/hooks",
            "issue_events_url": "https://api.github.com/repos/devtayls/opensource/issues/events{/number}",
            "events_url": "https://api.github.com/repos/devtayls/opensource/events",
            "assignees_url": "https://api.github.com/repos/devtayls/opensource/assignees{/user}",
            "branches_url": "https://api.github.com/repos/devtayls/opensource/branches{/branch}",
            "tags_url": "https://api.github.com/repos/devtayls/opensource/tags",
            "blobs_url": "https://api.github.com/repos/devtayls/opensource/git/blobs{/sha}",
            "git_tags_url": "https://api.github.com/repos/devtayls/opensource/git/tags{/sha}",
            "git_refs_url": "https://api.github.com/repos/devtayls/opensource/git/refs{/sha}",
            "trees_url": "https://api.github.com/repos/devtayls/opensource/git/trees{/sha}",
            "statuses_url": "https://api.github.com/repos/devtayls/opensource/statuses/{sha}",
            "languages_url": "https://api.github.com/repos/devtayls/opensource/languages",
            "stargazers_url": "https://api.github.com/repos/devtayls/opensource/stargazers",
            "contributors_url": "https://api.github.com/repos/devtayls/opensource/contributors",
            "subscribers_url": "https://api.github.com/repos/devtayls/opensource/subscribers",
            "subscription_url": "https://api.github.com/repos/devtayls/opensource/subscription",
            "commits_url": "https://api.github.com/repos/devtayls/opensource/commits{/sha}",
            "git_commits_url": "https://api.github.com/repos/devtayls/opensource/git/commits{/sha}",
            "comments_url": "https://api.github.com/repos/devtayls/opensource/comments{/number}",
            "issue_comment_url": "https://api.github.com/repos/devtayls/opensource/issues/comments{/number}",
            "contents_url": "https://api.github.com/repos/devtayls/opensource/contents/{+path}",
            "compare_url": "https://api.github.com/repos/devtayls/opensource/compare/{base}...{head}",
            "merges_url": "https://api.github.com/repos/devtayls/opensource/merges",
            "archive_url": "https://api.github.com/repos/devtayls/opensource/{archive_format}{/ref}",
            "downloads_url": "https://api.github.com/repos/devtayls/opensource/downloads",
            "issues_url": "https://api.github.com/repos/devtayls/opensource/issues{/number}",
            "pulls_url": "https://api.github.com/repos/devtayls/opensource/pulls{/number}",
            "milestones_url": "https://api.github.com/repos/devtayls/opensource/milestones{/number}",
            "notifications_url": "https://api.github.com/repos/devtayls/opensource/notifications{?since,all,participating}",
            "labels_url": "https://api.github.com/repos/devtayls/opensource/labels{/name}",
            "releases_url": "https://api.github.com/repos/devtayls/opensource/releases{/id}",
            "deployments_url": "https://api.github.com/repos/devtayls/opensource/deployments",
            "created_at": "2021-10-11T04:01:08Z",
            "updated_at": "2021-10-11T04:01:09Z",
            "pushed_at": "2021-10-11T04:06:50Z",
            "git_url": "git://github.com/devtayls/opensource.git",
            "ssh_url": "git@github.com:devtayls/opensource.git",
            "clone_url": "https://github.com/devtayls/opensource.git",
            "svn_url": "https://github.com/devtayls/opensource",
            "homepage": "https://opensource.uclaacm.com",
            "size": 1484,
            "stargazers_count": 0,
            "watchers_count": 0,
            "language": null,
            "has_issues": false,
            "has_projects": true,
            "has_downloads": true,
            "has_wiki": true,
            "has_pages": false,
            "forks_count": 0,
            "mirror_url": null,
            "archived": false,
            "disabled": false,
            "open_issues_count": 0,
            "license": {
              "key": "mit",
              "name": "MIT License",
              "spdx_id": "MIT",
              "url": "https://api.github.com/licenses/mit",
              "node_id": "MDc6TGljZW5zZTEz"
            },
            "allow_forking": true,
            "is_template": false,
            "topics": [

            ],
            "visibility": "public",
            "forks": 0,
            "open_issues": 0,
            "watchers": 0,
            "default_branch": "main"
          }
        },
        "base": {
          "label": "uclaacm:main",
          "ref": "main",
          "sha": "e0c6a15ce08438c539165cf934342bd5775b8442",
          "user": {
            "login": "uclaacm",
            "id": 8324381,
            "node_id": "MDEyOk9yZ2FuaXphdGlvbjgzMjQzODE=",
            "avatar_url": "https://avatars.githubusercontent.com/u/8324381?v=4",
            "gravatar_id": "",
            "url": "https://api.github.com/users/uclaacm",
            "html_url": "https://github.com/uclaacm",
            "followers_url": "https://api.github.com/users/uclaacm/followers",
            "following_url": "https://api.github.com/users/uclaacm/following{/other_user}",
            "gists_url": "https://api.github.com/users/uclaacm/gists{/gist_id}",
            "starred_url": "https://api.github.com/users/uclaacm/starred{/owner}{/repo}",
            "subscriptions_url": "https://api.github.com/users/uclaacm/subscriptions",
            "organizations_url": "https://api.github.com/users/uclaacm/orgs",
            "repos_url": "https://api.github.com/users/uclaacm/repos",
            "events_url": "https://api.github.com/users/uclaacm/events{/privacy}",
            "received_events_url": "https://api.github.com/users/uclaacm/received_events",
            "type": "Organization",
            "site_admin": false
          },
          "repo": {
            "id": 364504742,
            "node_id": "MDEwOlJlcG9zaXRvcnkzNjQ1MDQ3NDI=",
            "name": "opensource",
            "full_name": "uclaacm/opensource",
            "private": false,
            "owner": {
              "login": "uclaacm",
              "id": 8324381,
              "node_id": "MDEyOk9yZ2FuaXphdGlvbjgzMjQzODE=",
              "avatar_url": "https://avatars.githubusercontent.com/u/8324381?v=4",
              "gravatar_id": "",
              "url": "https://api.github.com/users/uclaacm",
              "html_url": "https://github.com/uclaacm",
              "followers_url": "https://api.github.com/users/uclaacm/followers",
              "following_url": "https://api.github.com/users/uclaacm/following{/other_user}",
              "gists_url": "https://api.github.com/users/uclaacm/gists{/gist_id}",
              "starred_url": "https://api.github.com/users/uclaacm/starred{/owner}{/repo}",
              "subscriptions_url": "https://api.github.com/users/uclaacm/subscriptions",
              "organizations_url": "https://api.github.com/users/uclaacm/orgs",
              "repos_url": "https://api.github.com/users/uclaacm/repos",
              "events_url": "https://api.github.com/users/uclaacm/events{/privacy}",
              "received_events_url": "https://api.github.com/users/uclaacm/received_events",
              "type": "Organization",
              "site_admin": false
            },
            "html_url": "https://github.com/uclaacm/opensource",
            "description": "opensource @ acm (but for now, matt's playground)",
            "fork": false,
            "url": "https://api.github.com/repos/uclaacm/opensource",
            "forks_url": "https://api.github.com/repos/uclaacm/opensource/forks",
            "keys_url": "https://api.github.com/repos/uclaacm/opensource/keys{/key_id}",
            "collaborators_url": "https://api.github.com/repos/uclaacm/opensource/collaborators{/collaborator}",
            "teams_url": "https://api.github.com/repos/uclaacm/opensource/teams",
            "hooks_url": "https://api.github.com/repos/uclaacm/opensource/hooks",
            "issue_events_url": "https://api.github.com/repos/uclaacm/opensource/issues/events{/number}",
            "events_url": "https://api.github.com/repos/uclaacm/opensource/events",
            "assignees_url": "https://api.github.com/repos/uclaacm/opensource/assignees{/user}",
            "branches_url": "https://api.github.com/repos/uclaacm/opensource/branches{/branch}",
            "tags_url": "https://api.github.com/repos/uclaacm/opensource/tags",
            "blobs_url": "https://api.github.com/repos/uclaacm/opensource/git/blobs{/sha}",
            "git_tags_url": "https://api.github.com/repos/uclaacm/opensource/git/tags{/sha}",
            "git_refs_url": "https://api.github.com/repos/uclaacm/opensource/git/refs{/sha}",
            "trees_url": "https://api.github.com/repos/uclaacm/opensource/git/trees{/sha}",
            "statuses_url": "https://api.github.com/repos/uclaacm/opensource/statuses/{sha}",
            "languages_url": "https://api.github.com/repos/uclaacm/opensource/languages",
            "stargazers_url": "https://api.github.com/repos/uclaacm/opensource/stargazers",
            "contributors_url": "https://api.github.com/repos/uclaacm/opensource/contributors",
            "subscribers_url": "https://api.github.com/repos/uclaacm/opensource/subscribers",
            "subscription_url": "https://api.github.com/repos/uclaacm/opensource/subscription",
            "commits_url": "https://api.github.com/repos/uclaacm/opensource/commits{/sha}",
            "git_commits_url": "https://api.github.com/repos/uclaacm/opensource/git/commits{/sha}",
            "comments_url": "https://api.github.com/repos/uclaacm/opensource/comments{/number}",
            "issue_comment_url": "https://api.github.com/repos/uclaacm/opensource/issues/comments{/number}",
            "contents_url": "https://api.github.com/repos/uclaacm/opensource/contents/{+path}",
            "compare_url": "https://api.github.com/repos/uclaacm/opensource/compare/{base}...{head}",
            "merges_url": "https://api.github.com/repos/uclaacm/opensource/merges",
            "archive_url": "https://api.github.com/repos/uclaacm/opensource/{archive_format}{/ref}",
            "downloads_url": "https://api.github.com/repos/uclaacm/opensource/downloads",
            "issues_url": "https://api.github.com/repos/uclaacm/opensource/issues{/number}",
            "pulls_url": "https://api.github.com/repos/uclaacm/opensource/pulls{/number}",
            "milestones_url": "https://api.github.com/repos/uclaacm/opensource/milestones{/number}",
            "notifications_url": "https://api.github.com/repos/uclaacm/opensource/notifications{?since,all,participating}",
            "labels_url": "https://api.github.com/repos/uclaacm/opensource/labels{/name}",
            "releases_url": "https://api.github.com/repos/uclaacm/opensource/releases{/id}",
            "deployments_url": "https://api.github.com/repos/uclaacm/opensource/deployments",
            "created_at": "2021-05-05T08:09:21Z",
            "updated_at": "2021-10-11T03:06:27Z",
            "pushed_at": "2021-10-11T04:09:39Z",
            "git_url": "git://github.com/uclaacm/opensource.git",
            "ssh_url": "git@github.com:uclaacm/opensource.git",
            "clone_url": "https://github.com/uclaacm/opensource.git",
            "svn_url": "https://github.com/uclaacm/opensource",
            "homepage": "https://opensource.uclaacm.com",
            "size": 1486,
            "stargazers_count": 2,
            "watchers_count": 2,
            "language": "TypeScript",
            "has_issues": true,
            "has_projects": true,
            "has_downloads": true,
            "has_wiki": true,
            "has_pages": false,
            "forks_count": 2,
            "mirror_url": null,
            "archived": false,
            "disabled": false,
            "open_issues_count": 6,
            "license": {
              "key": "mit",
              "name": "MIT License",
              "spdx_id": "MIT",
              "url": "https://api.github.com/licenses/mit",
              "node_id": "MDc6TGljZW5zZTEz"
            },
            "allow_forking": true,
            "is_template": false,
            "topics": [

            ],
            "visibility": "public",
            "forks": 2,
            "open_issues": 6,
            "watchers": 2,
            "default_branch": "main"
          }
        },
        "_links": {
          "self": {
            "href": "https://api.github.com/repos/uclaacm/opensource/pulls/13"
          },
          "html": {
            "href": "https://github.com/uclaacm/opensource/pull/13"
          },
          "issue": {
            "href": "https://api.github.com/repos/uclaacm/opensource/issues/13"
          },
          "comments": {
            "href": "https://api.github.com/repos/uclaacm/opensource/issues/13/comments"
          },
          "review_comments": {
            "href": "https://api.github.com/repos/uclaacm/opensource/pulls/13/comments"
          },
          "review_comment": {
            "href": "https://api.github.com/repos/uclaacm/opensource/pulls/comments{/number}"
          },
          "commits": {
            "href": "https://api.github.com/repos/uclaacm/opensource/pulls/13/commits"
          },
          "statuses": {
            "href": "https://api.github.com/repos/uclaacm/opensource/statuses/660c4610f8c332835e0777625cf7ba4b981b1d4a"
          }
        },
        "author_association": "NONE",
        "auto_merge": null,
        "active_lock_reason": null
      }
    },
    "public": true,
    "created_at": "2021-10-11T04:29:05Z",
    "org": {
      "id": 8324381,
      "login": "uclaacm",
      "gravatar_id": "",
      "url": "https://api.github.com/orgs/uclaacm",
      "avatar_url": "https://avatars.githubusercontent.com/u/8324381?"
    }
  },