Implement delete_versioned_model API #602

withsmilo · 2018-12-03T23:08:39Z

1. in brief

related issue : Suggestion - API scheme improvement #603
Remove the specified versions of the specified models from Clipper internal.

2. TODO

Implement unregister_versioned_models Clipper API in clipper_admin
Implement delete_versioned_model Management-Frontend API
Add some test cases to integration-tests/clipper_admin_tests.py
Add some test cases to src/management/src/management_frontend_tests.cpp

3. non-public `_unregister_versioned_models` Clipper API in clipper_admin

Description

Unregister the specified versions of the specified models from Clipper internal.
This function does not be opened to public because it might cause critical operation.
Please use stop_models, stop_versioned_models, stop_inactive_model_versions, and stop_all_model_containers APIs according to your need.

Parameters

model_versions_dict : dict(str, list(str))
For each entry in the dict, the key is a model name and the value is a list of model

Raises

:py:exc:clipper.UnconnectedException
versions. All replicas for each version of each model will be stopped.

4. `delete_versioned_model` Management-Frontend API

API path

POST /admin/delete_versioned_model

Request schema

const std::string DELETE_VERSIONED_MODEL_JSON_SCHEMA = R"(
{
"model_name" := string,
"model_version" := string,
}
)";

AmplabJenkins · 2018-12-03T23:09:24Z

Can one of the admins verify this patch?

avinregmi · 2019-02-14T00:08:32Z

Hey guys, I'm not getting the changes when installed using pip. Has this not been pushed in master yet?

withsmilo · 2019-02-14T14:21:27Z

@avinregmi : This pull request was NOT merged with develop branch yet. After fixing unstable CI infra, I will try to merge this.

* Remove the specified versions of the specified models from Clipper internal. * Implemented `unregister_versioned_models` Clipper API in clipper_admin. > Description > ----------- > unregister_versioned_models(model_versions_dict) > Parameters > ---------- > model_versions_dict : dict(str, list(str)) > For each entry in the dict, the key is a model name and the value is a list of model > Raises > ------ > :py:exc:`clipper.UnconnectedException` > versions. All replicas for each version of each model will be stopped. * Implemented `delete_versioned_model` Management-Frontend API. > API path > -------- > POST /admin/delete_versioned_model > Request schema > -------------- > const std::string DELETE_VERSIONED_MODEL_JSON_SCHEMA = R"( > { > "model_name" := string, > "model_version" := string, > } > )";

withsmilo · 2019-03-25T08:08:48Z

jenkins test this please

AmplabJenkins · 2019-03-25T08:13:57Z

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Clipper-PRB/1821/
Test FAILed.

withsmilo · 2019-03-25T08:15:15Z

Jenkins ok to test

AmplabJenkins · 2019-03-25T08:18:45Z

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Clipper-PRB/1822/
Test FAILed.

withsmilo · 2019-03-25T12:53:29Z

jenkins test this please

AmplabJenkins · 2019-03-25T13:18:10Z

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Clipper-PRB/1824/
Test FAILed.

This patch is needed to retry if 'docker push' fails. I found this error case through ucbrise#602 (comment).

withsmilo · 2019-03-25T14:01:35Z

jenkins test this please

AmplabJenkins · 2019-03-25T14:44:23Z

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Clipper-PRB/1826/
Test FAILed.

AmplabJenkins · 2019-03-25T16:22:03Z

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Clipper-PRB/1828/
Test FAILed.

* Add retry-routine to 'docker push' in clipper_docker.cfg.py This patch is needed to retry if 'docker push' fails. I found this error case through #602 (comment). * Move wait_and_pull_cmd() and wait_and_push_cmd() to proper location

AmplabJenkins · 2019-04-01T23:19:56Z

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Clipper-PRB/1880/
Test FAILed.

withsmilo · 2019-04-02T00:01:36Z

The latest Jenkins job shows me that the TaskExecutor has some bugs. I will try to debug it tonight.

AmplabJenkins · 2019-04-05T17:19:30Z

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Clipper-PRB/1889/
Test FAILed.

withsmilo · 2019-05-22T02:08:21Z

https://amplab.cs.berkeley.edu/jenkins//job/Clipper-PRB/2012/ shows,

 [py35-rpc]   ERROR: Complete output from command /usr/local/bin/python -u -c 'import setuptools, tokenize;__file__='"'"'/tmp/pip-req-build-mv0jvuu_/setup.py'"'"';f=getattr(tokenize, '"'"'open'"'"', open)(__file__);code=f.read().replace('"'"'\r\n'"'"', '"'"'\n'"'"');f.close();exec(compile(code, __file__, '"'"'exec'"'"'))' bdist_wheel -d /tmp/pip-wheel-4xpgl5lj --python-tag cp35: 
 [py35-rpc]   ERROR: /usr/local/lib/python3.5/site-packages/setuptools/dist.py:407: UserWarning: The version specified ('e70f089044') is an invalid version, this may not work as expected with newer versions of setuptools, pip, and PyPI. Please see PEP 440 for more details. 
...
 [py35-rpc] creating build/bdist.linux-x86_64/wheel/clipper_admin-e70f089044.dist-info/WHEEL 
 [py35-rpc] Traceback (most recent call last): 
 [py35-rpc] File "<string>", line 1, in <module> 
 [py35-rpc] File "/tmp/pip-req-build-mv0jvuu_/setup.py", line 33, in <module> 
 [py35-rpc] 'TensorFlow': ['tensorflow'], 
 [py35-rpc] File "/usr/local/lib/python3.5/site-packages/setuptools/__init__.py", line 140, in setup 
 [py35-rpc] return distutils.core.setup(**attrs) 
 [py35-rpc] File "/usr/local/lib/python3.5/distutils/core.py", line 148, in setup 
 [py35-rpc] dist.run_commands() 
 [py35-rpc] File "/usr/local/lib/python3.5/distutils/dist.py", line 955, in run_commands 
 [py35-rpc] self.run_command(cmd) 
 [py35-rpc] File "/usr/local/lib/python3.5/distutils/dist.py", line 974, in run_command 
 [py35-rpc] cmd_obj.run() 
 [py35-rpc] File "/usr/local/lib/python3.5/site-packages/wheel/bdist_wheel.py", line 246, in run 
 [py35-rpc] with WheelFile(wheel_path, 'w') as wf: 
 [py35-rpc] File "/usr/local/lib/python3.5/site-packages/wheel/wheelfile.py", line 40, in __init__ 
 [py35-rpc] raise WheelError("Bad wheel filename {!r}".format(basename)) 
 [py35-rpc] wheel.cli.WheelError: Bad wheel filename 'clipper_admin-e70f089044-py2.py3-none-any.whl' 
 [py35-rpc] ---------------------------------------- 
 [py35-rpc]   ERROR: Failed building wheel for clipper-admin

 [integration_py2_mxnet] Sleep 65 secs before starting a test 
 [integration_py2_mxnet] Starting Trial 0 with timeout 2400.0 seconds 
 [integration_py2_mxnet] Sleep 95 
 [integration_py2_mxnet] Starting Trial 1 with timeout 2400.0 seconds 
 [integration_py2_mxnet] Sleep 127 
 [integration_py2_mxnet] All retry failed. 
CI_test.Makefile:152: recipe for target 'integration_py2_mxnet' failed
make: *** [integration_py2_mxnet] Error 1

withsmilo · 2019-05-22T06:13:39Z

jenkins test this please

AmplabJenkins · 2019-05-22T07:28:49Z

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Clipper-PRB/2013/
Test PASSed.

rkooo567 · 2019-05-24T05:13:52Z

@withsmilo Will review once the last test is added! I am a little busy this week.

* TestDeleteVersionedModelCorrect * TestDeleteVersionedModelMissingField * TestDeleteVersionedModelForNonexistentModel

…_versioned_models_python_api

AmplabJenkins · 2019-05-29T22:37:20Z

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Clipper-PRB/2039/
Test FAILed.

AmplabJenkins · 2019-05-29T23:10:54Z

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Clipper-PRB/2040/
Test FAILed.

* TestDeleteVersionedModelForInvalidModel

AmplabJenkins · 2019-05-30T00:59:04Z

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Clipper-PRB/2041/
Test FAILed.

AmplabJenkins · 2019-05-30T01:17:28Z

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Clipper-PRB/2042/
Test FAILed.

AmplabJenkins · 2019-05-30T02:40:34Z

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Clipper-PRB/2043/
Test PASSed.

simon-mo

@withsmilo great work! thank you for implementing this. This is the missing piece in the Clipper API

Implement delete_versioned_model API (ucbrise#602)

withsmilo self-assigned this Dec 3, 2018

withsmilo force-pushed the implement_delete_versioned_models_python_api branch from 910f587 to fa5502a Compare December 4, 2018 00:52

simon-mo added the type: enhancement label Jan 1, 2019

withsmilo mentioned this pull request Feb 14, 2019

How to stop specific version of served model ? #601

Closed

withsmilo force-pushed the implement_delete_versioned_models_python_api branch from fa5502a to 28a2adf Compare March 22, 2019 13:10

Fix build error

821e64e

withsmilo pushed a commit to withsmilo/clipper that referenced this pull request Mar 25, 2019

Add retry-routine to 'docker push' in clipper_docker.cfg.py

8113f4e

This patch is needed to retry if 'docker push' fails. I found this error case through ucbrise#602 (comment).

withsmilo mentioned this pull request Mar 25, 2019

[CI] Add retry-routine to 'docker push' in clipper_docker.cfg.py #655

Merged

Fix unit test error

e86468c

solved conflicts

58fdef6

simon-mo previously approved these changes Apr 1, 2019

View reviewed changes

Sungjun, Kim added 2 commits April 5, 2019 23:40

Merge branch 'develop' into implement_delete_versioned_models_python_api

21d74f4

Refactor TaskExecutor and fix bugs

9ecb533

Change _unregister_versioned_models API to private at clipper_admin

5d2822c

Sungjun, Kim added 2 commits May 30, 2019 07:24

Add three unittests to management_frontend_tests

49ae746

* TestDeleteVersionedModelCorrect * TestDeleteVersionedModelMissingField * TestDeleteVersionedModelForNonexistentModel

Merge remote-tracking branch 'official/develop' into implement_delete…

03b6f6d

…_versioned_models_python_api

Fix build errors

bb57433

Sungjun, Kim added 2 commits May 30, 2019 09:46

Add one unittest to management_frontend_tests

e5fc561

* TestDeleteVersionedModelForInvalidModel

Fix TestDeleteVersionedModelCorrect unittest

eab8e81

Fix build error

45d29dd

Fix build error

b1cda95

withsmilo added status: needs review and removed status: needs revision labels May 30, 2019

withsmilo requested review from simon-mo and rkooo567 May 30, 2019 02:45

simon-mo approved these changes May 30, 2019

View reviewed changes

simon-mo merged commit 3d39dd7 into ucbrise:develop May 30, 2019

withsmilo deleted the implement_delete_versioned_models_python_api branch May 30, 2019 04:17

withsmilo added status: accepted and removed status: needs review labels May 30, 2019

jacekwachowiak added a commit to jacekwachowiak/clipper that referenced this pull request May 30, 2019

Merge pull request #6 from ucbrise/develop

5f6ee5c

Implement delete_versioned_model API (ucbrise#602)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Implement delete_versioned_model API #602

Implement delete_versioned_model API #602

withsmilo commented Dec 3, 2018 •

edited

Loading

AmplabJenkins commented Dec 3, 2018

avinregmi commented Feb 14, 2019

withsmilo commented Feb 14, 2019

withsmilo commented Mar 25, 2019

AmplabJenkins commented Mar 25, 2019

withsmilo commented Mar 25, 2019

AmplabJenkins commented Mar 25, 2019

withsmilo commented Mar 25, 2019

AmplabJenkins commented Mar 25, 2019

withsmilo commented Mar 25, 2019

AmplabJenkins commented Mar 25, 2019

AmplabJenkins commented Mar 25, 2019

AmplabJenkins commented Apr 1, 2019

withsmilo commented Apr 2, 2019

AmplabJenkins commented Apr 5, 2019

withsmilo commented May 22, 2019

withsmilo commented May 22, 2019

AmplabJenkins commented May 22, 2019

rkooo567 commented May 24, 2019

AmplabJenkins commented May 29, 2019

AmplabJenkins commented May 29, 2019

AmplabJenkins commented May 30, 2019

AmplabJenkins commented May 30, 2019

AmplabJenkins commented May 30, 2019

simon-mo left a comment

Implement delete_versioned_model API #602

Implement delete_versioned_model API #602

Conversation

withsmilo commented Dec 3, 2018 • edited Loading

1. in brief

2. TODO

3. non-public _unregister_versioned_models Clipper API in clipper_admin

Description

Parameters

Raises

4. delete_versioned_model Management-Frontend API

API path

Request schema

AmplabJenkins commented Dec 3, 2018

avinregmi commented Feb 14, 2019

withsmilo commented Feb 14, 2019

withsmilo commented Mar 25, 2019

AmplabJenkins commented Mar 25, 2019

withsmilo commented Mar 25, 2019

AmplabJenkins commented Mar 25, 2019

withsmilo commented Mar 25, 2019

AmplabJenkins commented Mar 25, 2019

withsmilo commented Mar 25, 2019

AmplabJenkins commented Mar 25, 2019

AmplabJenkins commented Mar 25, 2019

AmplabJenkins commented Apr 1, 2019

withsmilo commented Apr 2, 2019

AmplabJenkins commented Apr 5, 2019

withsmilo commented May 22, 2019

withsmilo commented May 22, 2019

AmplabJenkins commented May 22, 2019

rkooo567 commented May 24, 2019

AmplabJenkins commented May 29, 2019

AmplabJenkins commented May 29, 2019

AmplabJenkins commented May 30, 2019

AmplabJenkins commented May 30, 2019

AmplabJenkins commented May 30, 2019

simon-mo left a comment

Choose a reason for hiding this comment

withsmilo commented Dec 3, 2018 •

edited

Loading

3. non-public `_unregister_versioned_models` Clipper API in clipper_admin

4. `delete_versioned_model` Management-Frontend API