Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement delete_versioned_model API (#602) #6

Merged
merged 1 commit into from
May 30, 2019

Conversation

jacekwachowiak
Copy link
Owner

  • Implement delete_versioned_model API

  • Remove the specified versions of the specified models from Clipper internal.

  • Implemented unregister_versioned_models Clipper API in clipper_admin.

Description

unregister_versioned_models(model_versions_dict)

Parameters

model_versions_dict : dict(str, list(str))
For each entry in the dict, the key is a model name and the value is a list of model

Raises

:py:exc:clipper.UnconnectedException
versions. All replicas for each version of each model will be stopped.

  • Implemented delete_versioned_model Management-Frontend API.

API path

POST /admin/delete_versioned_model

Request schema

const std::string DELETE_VERSIONED_MODEL_JSON_SCHEMA = R"(
{
"model_name" := string,
"model_version" := string,
}
)";

  • Fix build error

  • Fix unit test error

  • Refactor TaskExecutor and fix bugs

  • Enhance the clean-up steps about useless model container

  • Add VersionedModelId to registered_containers_

  • Fix threadpool's bug

  • Call unregister_versioned_models() when stopped model containers

  • Update clipper_admin_tests.py

  • Fix TaskExecutor's bug

  • Change _unregister_versioned_models API to private at clipper_admin

  • Add three unittests to management_frontend_tests

  • TestDeleteVersionedModelCorrect

  • TestDeleteVersionedModelMissingField

  • TestDeleteVersionedModelForNonexistentModel

  • Fix build errors

  • Add one unittest to management_frontend_tests

  • TestDeleteVersionedModelForInvalidModel

  • Fix TestDeleteVersionedModelCorrect unittest

  • Fix build error

  • Fix build error

* Implement delete_versioned_model API

* Remove the specified versions of the specified models from Clipper internal.
* Implemented `unregister_versioned_models` Clipper API in clipper_admin.

> Description
> -----------
> unregister_versioned_models(model_versions_dict)

> Parameters
> ----------
> model_versions_dict : dict(str, list(str))
>     For each entry in the dict, the key is a model name and the value is a list of model

> Raises
> ------
> :py:exc:`clipper.UnconnectedException`
>     versions. All replicas for each version of each model will be stopped.

* Implemented `delete_versioned_model` Management-Frontend API.

> API path
> --------
> POST /admin/delete_versioned_model

> Request schema
> --------------
> const std::string DELETE_VERSIONED_MODEL_JSON_SCHEMA = R"(
>   {
>    "model_name" := string,
>    "model_version" := string,
>   }
> )";

* Fix build error

* Fix unit test error

* Refactor TaskExecutor and fix bugs

* Enhance the clean-up steps about useless model container

* Add VersionedModelId to registered_containers_

* Fix threadpool's bug

* Call unregister_versioned_models() when stopped model containers

* Update clipper_admin_tests.py

* Fix TaskExecutor's bug

* Change _unregister_versioned_models API to private at clipper_admin

* Add three unittests to management_frontend_tests

* TestDeleteVersionedModelCorrect
* TestDeleteVersionedModelMissingField
* TestDeleteVersionedModelForNonexistentModel

* Fix build errors

* Add one unittest to management_frontend_tests

* TestDeleteVersionedModelForInvalidModel

* Fix TestDeleteVersionedModelCorrect unittest

* Fix build error

* Fix build error
@jacekwachowiak jacekwachowiak merged commit 5f6ee5c into jacekwachowiak:develop May 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant