Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add config fragment for replacing L2 with broadcastManager #721

Merged
merged 1 commit into from
Dec 2, 2020
Merged

Add config fragment for replacing L2 with broadcastManager #721

merged 1 commit into from
Dec 2, 2020

Conversation

jerryz123
Copy link
Contributor

Related issue:
Surprisingly, there exists no predefined config fragment in rocketchip to set this.

Type of change: new feature

colinschmidt
colinschmidt approved these changes Nov 17, 2020
View reviewed changes
Copy link
Contributor

@colinschmidt colinschmidt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One doesn't exist upstream because it is the default value of this key. This makes sense for chipyard which assumes the default is an L2.

colinschmidt
colinschmidt reviewed Nov 17, 2020
View reviewed changes
Copy link
Contributor

@colinschmidt colinschmidt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Speaking of that default do we need to force nBanks = 1?

@colinschmidt
Copy link
Contributor

https://github.com/chipsalliance/rocket-chip/blob/c7d201f10eb14437d0303237a07b6890a0182309/src/main/scala/subsystem/BankedL2Params.scala#L29

@jerryz123
Copy link
Contributor Author

I think its orthogonal to nBanks.

@jerryz123 jerryz123 merged commit 70d4199 into dev Dec 2, 2020
@jerryz123 jerryz123 deleted the jerryz123-patch-1 branch December 24, 2020 05:20
@jerryz123 jerryz123 mentioned this pull request Jan 1, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@colinschmidt colinschmidt colinschmidt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jerryz123 @colinschmidt