Support diplomatic IOBinders #699
Conversation
jerryz123
force-pushed
the
lazy-iobinders
branch
from
208a96e
to
7a55c55
Compare
|
|
||
| abstract trait HasIOBinders { this: LazyModule => | ||
| val lazySystem: LazyModule | ||
| private val iobinders = p(IOBinders) |
There was a problem hiding this comment.
There is no "ApplyIOBinders" function right. So where do the IOBinder functions (both lazy and non-lazy) get called? I'm not exactly sure here.
There was a problem hiding this comment.
The evaluation of lzy and imp below evaluates the IOBinders, or wraps them in InModuleBody if they are not lazyiobinders. The implementation is a bit hairy because I wanted to avoid having to modify all of the existing concrete iobinders,
|
I hope this doesn't sound too pushy, but do you guys have an ETA on this being merged? I would like to try out some of these new features. Thanks! |
| }) | ||
| ) | ||
| }) | ||
| class OverrideHarnessBinder[T, S <: HasHarnessSignalReferences, U <: Data](fn: => (T, S, Seq[U]) => Seq[Any]) |
There was a problem hiding this comment.
I see we're approaching diplomacy-level type genericization.
| case system: T => composer(upfn)(system, th, pts) | ||
| case _ => | ||
| } | ||
| case _ => |
There was a problem hiding this comment.
@jerryz123 I'm bumping to start using this code. Can you help me understand why you need the empty default matching cases on lines 55 and 57 of the new file here (i.e. the case _ => lines)?
There was a problem hiding this comment.
I believe this was done to avoid MatchErrors. In the case where the type of the actual elaborated TestHarness does not match the expected Harness type, or in the case where type of the actual elaborated System does not match the expected System type, this expression just becomes a no-op.
This is useful because it lets us build up a collection of default HarnessBinders through Configs without thinking about exactly what hardware design is being requested.
Related issue:
OverrideLazyIOBinderandComposeLazyIOBinderAPIs to write IOBinders which modify diplomatic parametersmake TOP=DigitalTopand adds regression testType of change: new feature
Impact: software change
Release Notes