Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement fast loadmem feature #635

Merged
merged 2 commits into from
Aug 4, 2020
Merged

Implement fast loadmem feature #635

merged 2 commits into from
Aug 4, 2020

Conversation

zhemao
Copy link
Contributor

@zhemao zhemao commented Jul 30, 2020

Related issue: ucb-bar/testchipip#94

Type of change: new feature

Impact: software change

Release Notes

Implement fast loadmem feature for VCS/Verilator simulation

@zhemao zhemao requested a review from colinschmidt July 30, 2020 20:23
Copy link
Contributor

@colinschmidt colinschmidt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
Now we just need an elf2hex make fragment somewhere to really make this easy.

@colinschmidt
Copy link
Contributor

Why did you bump firesim? This PR seemed good before that

@colinschmidt colinschmidt mentioned this pull request Aug 3, 2020
@zhemao
Copy link
Contributor Author

zhemao commented Aug 3, 2020

Firesim was using the old load_mem function, so I had to change it to use the new functions. I'll merge this once David approves the FireSim PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants