Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix generation of env.sh for zsh #435

Merged
merged 1 commit into from
Feb 15, 2020
Merged

Fix generation of env.sh for zsh #435

merged 1 commit into from
Feb 15, 2020

Conversation

davidbiancolin
Copy link
Contributor

@davidbiancolin davidbiancolin commented Feb 15, 2020 •
edited
Loading

This fixes the env.sh generation for weirdos like me.

Type of change: A matter of perspective

Impact: software change

Release Notes
Make references to BASH_SOURCE also provide a zsh compatible default.

a0u
a0u approved these changes Feb 15, 2020
View reviewed changes
Copy link
Member

@a0u a0u left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am also a weirdo.

@davidbiancolin davidbiancolin merged commit 9d45a27 into dev Feb 15, 2020
@davidbiancolin davidbiancolin deleted the fix-init-zsh branch February 15, 2020 07:41
@sagark sagark mentioned this pull request Mar 13, 2020
Merged
@davidbiancolin davidbiancolin mentioned this pull request Nov 1, 2020
Merged
@davidbiancolin davidbiancolin mentioned this pull request Jun 11, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@a0u a0u a0u approved these changes

@zhemao zhemao Awaiting requested review from zhemao

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@davidbiancolin @a0u