Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dependabot to auto-update submodules #1940

Merged
merged 1 commit into from
Aug 2, 2024
Merged

Conversation

abejgonzalez
Copy link
Contributor

Opening this to spawn discussion on how/should we use this to update submodules. I think this is nice, but we should 1. configure how often it checks for things and 2. what it should update v.s. what we should do ourselves. In any case, the PRs that it opens still have to be manually approved (see FireSims PRs from dependabot: https://github.com/firesim/firesim/pulls)

Related PRs / Issues:

Type of change:

  • Bug fix
  • New feature
  • Other enhancement

Impact:

  • RTL change
  • Software change (RISC-V software)
  • Build system change
  • Other

Contributor Checklist:

  • Did you set main as the base branch?
  • Is this PR's title suitable for inclusion in the changelog and have you added a changelog:<topic> label?
  • Did you state the type-of-change/impact?
  • Did you delete any extraneous prints/debugging code?
  • Did you mark the PR with a changelog: label?
  • (If applicable) Did you update the conda .conda-lock.yml file if you updated the conda requirements file?
  • (If applicable) Did you add documentation for the feature?
  • (If applicable) Did you add a test demonstrating the PR?
  • (If applicable) Did you mark the PR as Please Backport?

@jerryz123
Copy link
Contributor

Will CI run on these PRs? A big limitation with the CIRCT action is that it doesn't run our CI.

@abejgonzalez
Copy link
Contributor Author

Yup. It will run the CI by default.

Copy link
Contributor

@jerryz123 jerryz123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm willing to try this out.

@abejgonzalez
Copy link
Contributor Author

Small update to instead ignore selected submodules instead of listing them all out. Merging since this doesn't affect CI.

@abejgonzalez abejgonzalez merged commit 1e3651b into main Aug 2, 2024
7 of 9 checks passed
@abejgonzalez abejgonzalez deleted the add-dependabot branch August 6, 2024 21:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants