Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the chipyard.jar cache was built with SBT_PROJECT (usually chipyard) as the top-level project. This causes a bug where after building the jar with SBT_PROJECT=chipyard, future fpga compilations (with SBT_PROJECT=fpga_platforms) would fail due to not rebuilding the cache.
This PR updates the build system to build a separate jar for the fpga flow that includes the fpga-specific sources.
This renames
fpga_platforms
tochipyard_fpga
to make it clearer that that project is an extension of chipyard with fpga configs.This renames
CHIPYARD_CLASSPATH
toGENERATOR_CLASSPATH
to make it clearer that the this classpath must contain aGenerator
main to run, but it does not have to be the chipyard project in build.sbtRelated PRs / Issues:
Type of change:
Impact:
Contributor Checklist:
main
as the base branch?changelog:<topic>
label?changelog:
label?.conda-lock.yml
file if you updated the conda requirements file?Please Backport
?