Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use SV48 when possible #1847

Merged
merged 1 commit into from
Apr 15, 2024
Merged

Use SV48 when possible #1847

merged 1 commit into from
Apr 15, 2024

Conversation

abejgonzalez
Copy link
Contributor

Default to using SV48 for 64b designs. Otherwise, adhere to the RC default (SV32).

Related PRs / Issues:

Type of change:

  • Bug fix
  • New feature
  • Other enhancement

Impact:

  • RTL change
  • Software change (RISC-V software)
  • Build system change
  • Other

Contributor Checklist:

  • Did you set main as the base branch?
  • Is this PR's title suitable for inclusion in the changelog and have you added a changelog:<topic> label?
  • Did you state the type-of-change/impact?
  • Did you delete any extraneous prints/debugging code?
  • Did you mark the PR with a changelog: label?
  • (If applicable) Did you update the conda .conda-lock.yml file if you updated the conda requirements file?
  • (If applicable) Did you add documentation for the feature?
  • (If applicable) Did you add a test demonstrating the PR?
  • (If applicable) Did you mark the PR as Please Backport?

@abejgonzalez
Copy link
Contributor Author

This was tested in a CY/FS setup on both BOOM and Rocket default designs (booting Linux - buildroot + Ubuntu).

@tymcauley
Copy link
Contributor

Just curious, what's the motivation behind this change? Working on designs with more than 512 GiB of virtual address space?

@abejgonzalez
Copy link
Contributor Author

Just curious, what's the motivation behind this change? Working on designs with more than 512 GiB of virtual address space?

Some projects here in Berkeley are using open-source code that uses SV48 as a default (for example: https://github.com/google/tcmalloc/blob/5ed309d3de0c647a91bb41b2be68603c39aef452/tcmalloc/internal/config.h#L135). So this is just matching the default VA space to those applications (since I think it's fairly innocuous to add more space).

@abejgonzalez abejgonzalez merged commit 1c9cc42 into main Apr 15, 2024
57 checks passed
@abejgonzalez abejgonzalez deleted the default-to-sv48 branch July 4, 2024 00:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants