Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for building CIRCT from source #1806

Merged
merged 7 commits into from
Feb 28, 2024
Merged

Add support for building CIRCT from source #1806

merged 7 commits into from
Feb 28, 2024

Conversation

jerryz123
Copy link
Contributor

Unfortunately, some machines we use cannot run the CIRCT nightlies, with no workaround besides building CIRCT from source.
This adds a script and flag to build-setup to build CIRCT from source.

Related PRs / Issues:

Type of change:

  • Bug fix
  • New feature
  • Other enhancement

Impact:

  • RTL change
  • Software change (RISC-V software)
  • Build system change
  • Other

Contributor Checklist:

  • Did you set main as the base branch?
  • Is this PR's title suitable for inclusion in the changelog and have you added a changelog:<topic> label?
  • Did you state the type-of-change/impact?
  • Did you delete any extraneous prints/debugging code?
  • Did you mark the PR with a changelog: label?
  • (If applicable) Did you update the conda .conda-lock.yml file if you updated the conda requirements file?
  • (If applicable) Did you add documentation for the feature?
  • (If applicable) Did you add a test demonstrating the PR?
  • (If applicable) Did you mark the PR as Please Backport?

Copy link
Contributor

@joonho3020 joonho3020 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@abejgonzalez abejgonzalez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it would be a good idea to change our full flow CI (which is used for CAD stuff + other) to use this flag (just to cover that the build works).

scripts/build-setup.sh Outdated Show resolved Hide resolved
Co-authored-by: Abraham Gonzalez <abe.j.gonza@gmail.com>
@jerryz123
Copy link
Contributor Author

I think it would be a good idea to change our full flow CI (which is used for CAD stuff + other) to use this flag (just to cover that the build works).

This does massively blow up the run time of that flow though.... I'm actually ok with not testing this in CI... its for one very specific environment. Very few people should use this.

@jerryz123 jerryz123 merged commit a2345c7 into main Feb 28, 2024
53 checks passed
@jerryz123 jerryz123 deleted the circt-source branch February 28, 2024 19:40
@seldridge
Copy link
Member

Drive by comments/ideas: Any caching can speed up the builds. This can either be "cache the whole CIRCT build result" or using ccache/sccache on top of a build and preserving the ccache/sccache across builds. The latter is usually easier to deal with and does have benefits of allowing caching across similar, but not identical builds.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants