-
Notifications
You must be signed in to change notification settings - Fork 653
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for building CIRCT from source #1806
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it would be a good idea to change our full flow CI (which is used for CAD stuff + other) to use this flag (just to cover that the build works).
Co-authored-by: Abraham Gonzalez <abe.j.gonza@gmail.com>
This does massively blow up the run time of that flow though.... I'm actually ok with not testing this in CI... its for one very specific environment. Very few people should use this. |
Drive by comments/ideas: Any caching can speed up the builds. This can either be "cache the whole CIRCT build result" or using ccache/sccache on top of a build and preserving the ccache/sccache across builds. The latter is usually easier to deal with and does have benefits of allowing caching across similar, but not identical builds. |
Unfortunately, some machines we use cannot run the CIRCT nightlies, with no workaround besides building CIRCT from source.
This adds a script and flag to build-setup to build CIRCT from source.
Related PRs / Issues:
Type of change:
Impact:
Contributor Checklist:
main
as the base branch?changelog:<topic>
label?changelog:
label?.conda-lock.yml
file if you updated the conda requirements file?Please Backport
?