Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump to Verilator v5.022 #1800

Merged
merged 1 commit into from
Feb 26, 2024
Merged

Bump to Verilator v5.022 #1800

merged 1 commit into from
Feb 26, 2024

Conversation

vighneshiyer
Copy link
Contributor

Related PRs / Issues:

Type of change:

  • Bug fix
  • New feature
  • Other enhancement

Impact:

  • RTL change
  • Software change (RISC-V software)
  • Build system change
  • Other

Contributor Checklist:

  • Did you set main as the base branch?
  • Is this PR's title suitable for inclusion in the changelog and have you added a changelog:<topic> label?
  • Did you state the type-of-change/impact?
  • Did you delete any extraneous prints/debugging code?
  • Did you mark the PR with a changelog: label?
  • (If applicable) Did you update the conda .conda-lock.yml file if you updated the conda requirements file?
  • (If applicable) Did you add documentation for the feature?
  • (If applicable) Did you add a test demonstrating the PR?
  • (If applicable) Did you mark the PR as Please Backport?

Verilator v5.020 has a bug when building a debug simulator (verilator/verilator#4860). Bumping the Verilator version resolves this issue.

Copy link
Contributor

@jerryz123 jerryz123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was there any particular motivation for this bump?

@vighneshiyer
Copy link
Contributor Author

Running make debug in verilator/sims with Verilator v5.020 causes the issue linked above. You can't compile a debug simulator

@jerryz123
Copy link
Contributor

Ah nice, Vikram was running into this

@vighneshiyer
Copy link
Contributor Author

@abejgonzalez Could you check on the CI? I'm able to run ./build-setup.sh on the Millennium machines just fine, but the CI fails during the conda-lock step. Maybe the base conda environment needs to be re-installed?

@jerryz123
Copy link
Contributor

The setup-repo step in some other currently running jobs worked fine.
I wonder if this is related to the Error: EBUSY: resource busy or locked failures.

@jerryz123
Copy link
Contributor

I think you just have to manually delete '/scratch/buildbot/actions-runner-7/_work/chipyard/chipyard/software/firemarshal/disk-mount` off the build machines

Copy link
Contributor

@abejgonzalez abejgonzalez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Pending CI passing.

@vighneshiyer vighneshiyer merged commit 3c5eab1 into main Feb 26, 2024
54 checks passed
@jerryz123 jerryz123 deleted the verilator_v5022_bump branch February 26, 2024 05:59
@abejgonzalez abejgonzalez mentioned this pull request Feb 28, 2024
3 tasks
@aignacio
Copy link

aignacio commented Jun 25, 2024

can you make another release with this fix? latest v1.11 is still on 5.20 which is broken... or maybe update the documentation.

@seldridge
Copy link
Member

seldridge commented Jun 25, 2024

Note that 5.022 has a major bug in force behavior if you are using that [1]. This is fixed in 5.024.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants