Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use non-lock-file conda requirements in RTD #1742

Merged
merged 2 commits into from
Jan 22, 2024
Merged

Conversation

abejgonzalez
Copy link
Contributor

@abejgonzalez abejgonzalez commented Jan 18, 2024

The RTD changed to not allow lock-files in the .readthedocs.yaml configuration. So now, lets instead use the environment file directly.

Related PRs / Issues:

Type of change:

  • Bug fix
  • New feature
  • Other enhancement

Impact:

  • RTL change
  • Software change (RISC-V software)
  • Build system change
  • Other

Contributor Checklist:

  • Did you set main as the base branch?
  • Is this PR's title suitable for inclusion in the changelog and have you added a changelog:<topic> label?
  • Did you state the type-of-change/impact?
  • Did you delete any extraneous prints/debugging code?
  • Did you mark the PR with a changelog: label?
  • (If applicable) Did you update the conda .conda-lock.yml file if you updated the conda requirements file?
  • (If applicable) Did you add documentation for the feature?
  • (If applicable) Did you add a test demonstrating the PR?
  • (If applicable) Did you mark the PR as Please Backport?

@abejgonzalez
Copy link
Contributor Author

Edit: Upon further inspection this seems like a RTD configuration issue where it isn't parsing the lock-file properly (instead of a pinned RTD theme issue).

@abejgonzalez abejgonzalez changed the title Pin sphinx_rtd_theme in Conda Use non-lock-file conda requirements in RTD Jan 18, 2024
@jerryz123
Copy link
Contributor

Are the CI failures related to this change?

@abejgonzalez
Copy link
Contributor Author

No they aren't and it's unclear why things would break. Couldn't get around to this today. I'll look over the weekend

@abejgonzalez
Copy link
Contributor Author

This was the issue. Downgrading OpenJDK <= 20 works. sbt/sbt#7235

@abejgonzalez abejgonzalez merged commit 8d866b1 into main Jan 22, 2024
104 of 105 checks passed
@abejgonzalez abejgonzalez deleted the pin-sphinx-rtd branch July 4, 2024 00:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants