Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX: remove clear screen character #1737

Closed
wants to merge 2 commits into from
Closed

FIX: remove clear screen character #1737

wants to merge 2 commits into from

Conversation

T-K-233
Copy link
Member

@T-K-233 T-K-233 commented Jan 12, 2024

Fixes Issue #1736

Related PRs / Issues:

Type of change:

  • Bug fix
  • New feature
  • Other enhancement

Impact:

  • RTL change
  • Software change (RISC-V software)
  • Build system change
  • Other

Contributor Checklist:

  • Did you set main as the base branch?
  • Is this PR's title suitable for inclusion in the changelog and have you added a changelog:<topic> label?
  • Did you state the type-of-change/impact?
  • Did you delete any extraneous prints/debugging code?
  • Did you mark the PR with a changelog: label?
  • (If applicable) Did you update the conda .conda-lock.yml file if you updated the conda requirements file?
  • (If applicable) Did you add documentation for the feature?
  • (If applicable) Did you add a test demonstrating the PR?
  • (If applicable) Did you mark the PR as Please Backport?

Copy link
Contributor

@abejgonzalez abejgonzalez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We want something like this to clearly indicate that there is a prompt that the user needs to type on (before the clear screen existed some users would miss that the prompt would appear and would context switch for a significant time before realizing it was a prompt). Maybe a compromise is to have a big block of text like this:

----------------------------------------------------------------------------
----------------------------------------------------------------------------
----------------------------------------------------------------------------
----------------------------------------------------------------------------
PROMPT HERE
----------------------------------------------------------------------------
----------------------------------------------------------------------------
----------------------------------------------------------------------------

@T-K-233 T-K-233 closed this Jan 22, 2024
@T-K-233
Copy link
Member Author

T-K-233 commented Jan 22, 2024

Close due to #1749 proposing an alternative solution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants