Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Install uart_tsi utility as part of build-toolchain-extra #1670

Merged
merged 1 commit into from
Nov 28, 2023
Merged

Install uart_tsi utility as part of build-toolchain-extra #1670

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions scripts/build-toolchain-extra.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -118,4 +118,11 @@ cd tools/DRAMSim2
make libdramsim.so
cp libdramsim.so $RISCV/lib/

echo '==> Installing uart_tsi bringup utility'
cd $RDIR
git submodule update --init generators/testchipip
cd generators/testchipip/uart_tsi
make
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This make step will fail on Mac since there are some baudrate constants that are missing on Mac's version of termios.h. Is there a reason we need to use termios baud rate constants? If we just replace them with the actual values it will work on Mac.

There's also some Linux warnings that end up erroring on Mac, so we should probably fix that before merging this in.

If having this work on Mac is important, I can make a PR to fix the uart_tsi code to work on Mac and linux.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't realize people were building this on Mac. Would this be the only thing that breaks the Mac build? If so, then we should fix this.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't actually built the extra toolchain on Mac, so if Mac isn't necessary to be supported we probably don't need to change uart_tsi. I only got uart_tsi to work on Mac but eventually just used a Linux VM since I only wanted to have the riscv-toolchain installed on Linux.

cp uart_tsi $RISCV/bin

echo "Extra Toolchain Utilities/Tests Build Complete!"