Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump FireMarshal for linux rng init fix #1620

Merged
merged 1 commit into from
Oct 11, 2023
Merged

Conversation

raghav-g13
Copy link
Contributor

Issue: In the absence of a hardware random number generator, applications are blocked on dev/urandom while the system gains entropy. Gaining entropy unnecessarily consumes lots of sim cycles and applications appear to silently hang.

This PR adds Kconfig options to firesim/linux and uses them in FireMarshal to artificially set entropy during early boot.

Related PRs / Issues:

  • firesim/FireMarshal : rng init fix: update firesim/linux submodule + update linux-config to use Kconfig options #289
  • firesim/linux : Initialize random number generator in early boot #4

Type of change:

  • Bug fix
  • New feature
  • Other enhancement

Impact:

  • RTL change
  • Software change (RISC-V software)
  • Build system change
  • Other

Contributor Checklist:

  • Did you set main as the base branch?
  • Is this PR's title suitable for inclusion in the changelog and have you added a changelog:<topic> label?
  • Did you state the type-of-change/impact?
  • Did you delete any extraneous prints/debugging code?
  • Did you mark the PR with a changelog: label?
  • (If applicable) Did you update the conda .conda-lock.yml file if you updated the conda requirements file?
  • (If applicable) Did you add documentation for the feature?
  • (If applicable) Did you add a test demonstrating the PR?
  • (If applicable) Did you mark the PR as Please Backport?

@jerryz123 jerryz123 merged commit 73efea0 into main Oct 11, 2023
53 of 54 checks passed
@jerryz123 jerryz123 deleted the marshal-rng-init-bump branch October 11, 2023 21:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants