Fix icenet-loopback clock and reset domain #1612
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pipe
in https://github.com/firesim/icenet/blob/bbce029e3d3e4b11578f380ad48012fc49247d60/src/main/scala/NIC.scala#L603 is set on a different clock & reset domain than external ports of the NIC, causing thenic-loopback
test to fail.This PR fixes this by explicitly setting the clock & reset domain in the testharness for NIC loopbacks.
Related PRs / Issues:
Related PR
Type of change:
Impact:
Contributor Checklist:
main
as the base branch?changelog:<topic>
label?changelog:
label?.conda-lock.yml
file if you updated the conda requirements file?Please Backport
?