Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve peripheral config binders (Reapply #1511) #1527

Merged
merged 8 commits into from
Jul 10, 2023
Merged

Improve peripheral config binders (Reapply #1511) #1527

merged 8 commits into from
Jul 10, 2023

Conversation

jerryz123
Copy link
Contributor

@jerryz123 jerryz123 commented Jun 19, 2023 •
edited
Loading

This reapplies #1511, while also keeping the default parameter order for WithUART/WithSPIFlash, so legacy configs which use those fragments will maintain the same behavior.

Do not merge until after 1.10.0

Related PRs / Issues:

Type of change:

  • Bug fix
  • New feature
  • Other enhancement

Impact:

  • RTL change
  • Software change (RISC-V software)
  • Build system change
  • Other

Contributor Checklist:

  • Did you set main as the base branch?
  • Is this PR's title suitable for inclusion in the changelog and have you added a changelog:<topic> label?
  • Did you state the type-of-change/impact?
  • Did you delete any extraneous prints/debugging code?
  • Did you mark the PR with a changelog: label?
  • (If applicable) Did you update the conda .conda-lock.yml file if you updated the conda requirements file?
  • (If applicable) Did you add documentation for the feature?
  • (If applicable) Did you add a test demonstrating the PR?
  • (If applicable) Did you mark the PR as Please Backport?

@jerryz123 jerryz123 requested a review from T-K-233 June 19, 2023 12:05
@jerryz123 jerryz123 changed the title Revert "Revert Merge pull request #1511 from ucb-bar/improve-peripherals" Improve peripheral config binders (Reapply #1511) Jul 10, 2023
abejgonzalez
abejgonzalez approved these changes Jul 10, 2023
View reviewed changes
Copy link
Contributor

@abejgonzalez abejgonzalez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jerryz123 jerryz123 merged commit 3c670cb into main Jul 10, 2023
@jerryz123 jerryz123 deleted the readd-better-peripherals branch July 10, 2023 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abejgonzalez abejgonzalez abejgonzalez approved these changes

@T-K-233 T-K-233 Awaiting requested review from T-K-233

Assignees
No one assigned
Labels
changelog:added
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jerryz123 @abejgonzalez @T-K-233