Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch RTL sims to absolute clock-generators #1472

Merged
merged 12 commits into from
May 12, 2023
Merged

Switch RTL sims to absolute clock-generators #1472

merged 12 commits into from
May 12, 2023

Conversation

jerryz123
Copy link
Contributor

@jerryz123 jerryz123 commented May 10, 2023

Which verilator v5, we can use absolute clock generators in all RTL simulators, which means we can ditch DividerOnlyClockGenerator.

  • Default configs punch out all clocks to Harness
  • Default RTL harness uses ClockWithFreq unsynthesizable verilog to emit clocks for each requested clock domain

Related PRs / Issues:

Type of change:

  • Bug fix
  • New feature
  • Other enhancement

Impact:

  • RTL change
  • Software change (RISC-V software)
  • Build system change
  • Other

Contributor Checklist:

  • Did you set main as the base branch?
  • Is this PR's title suitable for inclusion in the changelog and have you added a changelog:<topic> label?
  • Did you state the type-of-change/impact?
  • Did you delete any extraneous prints/debugging code?
  • Did you mark the PR with a changelog: label?
  • (If applicable) Did you update the conda .conda-lock.yml file if you updated the conda requirements file?
  • (If applicable) Did you add documentation for the feature?
  • (If applicable) Did you add a test demonstrating the PR?
  • (If applicable) Did you mark the PR as Please Backport?

@jerryz123
Copy link
Contributor Author

I had to bump up the frequencies of the uncore to pass tests in time, previously the thing configured a 100MHz uncore, but ran it at 1 GHz with the TestDriver clock.

@jerryz123 jerryz123 merged commit 27f78da into main May 12, 2023
@jerryz123 jerryz123 deleted the simpleclocks branch May 12, 2023 04:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants