Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate out conda-lock generation into new script #1466

Merged
merged 2 commits into from
May 10, 2023

Conversation

abejgonzalez
Copy link
Contributor

This makes it easier to regenerate conda lock files without having to run the entire build setup. Instead, users just need to run the generate-conda-lockfile.sh script. This also bounds s3fs to match the version in FireSim (you can now run the FireSim pytests with Chipyard as top packages)

Related PRs / Issues:

Type of change:

  • Bug fix
  • New feature
  • Other enhancement

Impact:

  • RTL change
  • Software change (RISC-V software)
  • Build system change
  • Other

Contributor Checklist:

  • Did you set main as the base branch?
  • Is this PR's title suitable for inclusion in the changelog and have you added a changelog:<topic> label?
  • Did you state the type-of-change/impact?
  • Did you delete any extraneous prints/debugging code?
  • Did you mark the PR with a changelog: label?
  • (If applicable) Did you update the conda .conda-lock.yml file if you updated the conda requirements file?
  • (If applicable) Did you add documentation for the feature?
  • (If applicable) Did you add a test demonstrating the PR?
  • (If applicable) Did you mark the PR as Please Backport?

@abejgonzalez abejgonzalez self-assigned this May 9, 2023
Copy link
Contributor

@harrisonliew harrisonliew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can the script just generate both the riscv-tools and esp-tools lockfiles instead of requiring you to run twice and change the TOOLCHAIN_TYPE variable?

@abejgonzalez abejgonzalez merged commit 8fa12e3 into main May 10, 2023
@abejgonzalez abejgonzalez deleted the sync-params-n-script branch August 6, 2024 21:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants