Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ADD: improve Makefile in tests/, add explicit arch flags #1439

Merged
merged 1 commit into from
Apr 13, 2023
Merged

ADD: improve Makefile in tests/, add explicit arch flags #1439

merged 1 commit into from
Apr 13, 2023

Conversation

T-K-233
Copy link
Member

@T-K-233 T-K-233 commented Apr 13, 2023

changelog:omit

Minor change. Added the complete variable definition of the riscv64-unknown-elf- toolchain. Added the ARCH and ABI flags definitions.

The default compilation flow is not affected.

Related PRs / Issues:

Type of change:

  • Bug fix
  • New feature
  • Other enhancement

Impact:

  • RTL change
  • Software change (RISC-V software)
  • Build system change
  • Other

Contributor Checklist:

  • Did you set main as the base branch?
  • Is this PR's title suitable for inclusion in the changelog and have you added a changelog:<topic> label?
  • Did you state the type-of-change/impact?
  • Did you delete any extraneous prints/debugging code?
  • Did you mark the PR with a changelog: label?
  • (If applicable) Did you update the conda .conda-lock.yml file if you updated the conda requirements file?
  • (If applicable) Did you add documentation for the feature?
  • (If applicable) Did you add a test demonstrating the PR?
  • (If applicable) Did you mark the PR as Please Backport?

@jerryz123
Copy link
Contributor

I'll give you write permissions to chipyard. For future PRs, can you push the branch directly into Chipyard? Then the CI can run, and we don't have to create copies of PRs.

@jerryz123 jerryz123 merged commit 10c2625 into ucb-bar:main Apr 13, 2023
@T-K-233 T-K-233 deleted the better-tests branch June 11, 2023 07:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants