Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump to latest rocket-chip/chisel3.5.6 #1411

Merged
merged 13 commits into from
Apr 8, 2023
Merged

Bump to latest rocket-chip/chisel3.5.6 #1411

merged 13 commits into from
Apr 8, 2023

Conversation

jerryz123
Copy link
Contributor

@jerryz123 jerryz123 commented Mar 21, 2023 •
edited
Loading

Related PRs / Issues:

Type of change:

  • Bug fix
  • New feature
  • Other enhancement

Impact:

  • RTL change
  • Software change (RISC-V software)
  • Build system change
  • Other

Contributor Checklist:

  • Did you set main as the base branch?
  • Is this PR's title suitable for inclusion in the changelog and have you added a changelog:<topic> label?
  • Did you state the type-of-change/impact?
  • Did you delete any extraneous prints/debugging code?
  • Did you mark the PR with a changelog: label?
  • (If applicable) Did you update the conda .conda-lock.yml file if you updated the conda requirements file?
  • (If applicable) Did you add documentation for the feature?
  • (If applicable) Did you add a test demonstrating the PR?
  • (If applicable) Did you mark the PR as Please Backport?

@abejgonzalez
Copy link
Contributor

SFTM on a first glance.

@jerryz123 jerryz123 mentioned this pull request Mar 30, 2023
Merged
18 tasks
@jerryz123 jerryz123 marked this pull request as ready for review April 4, 2023 18:36
abejgonzalez
abejgonzalez approved these changes Apr 7, 2023
View reviewed changes
Copy link
Contributor

@abejgonzalez abejgonzalez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jerryz123 jerryz123 merged commit af6a88d into main Apr 8, 2023
@jerryz123 jerryz123 mentioned this pull request Apr 8, 2023
Merged
16 tasks
@jerryz123 jerryz123 deleted the chisel356 branch April 18, 2023 01:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abejgonzalez abejgonzalez abejgonzalez approved these changes

Assignees
No one assigned
Labels
changelog:changed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jerryz123 @abejgonzalez